mbedtls: RSA PKCS8 import slices wrong DER object#598
Open
jedisct1 wants to merge 1 commit intoh2o:masterfrom
Open
mbedtls: RSA PKCS8 import slices wrong DER object#598jedisct1 wants to merge 1 commit intoh2o:masterfrom
jedisct1 wants to merge 1 commit intoh2o:masterfrom
Conversation
`ptls_mbedtls_load_private_key` unwraps PKCS#8 `BEGIN PRIVATE KEY` material with `test_parse_private_key_field`, yielding `key_index` and `key_length` for the inner private-key OCTET STRING payload. In the RSA branch, the code then switches back to the outer PKCS#8 buffer and length before deriving RSA attributes and calling `psa_import_key`. As a result, RSA-specific parsing receives a `PrivateKeyInfo` object instead of the required inner `RSAPrivateKey` DER object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ptls_mbedtls_load_private_keyunwraps PKCS#8BEGIN PRIVATE KEYmaterial withtest_parse_private_key_field, yieldingkey_indexandkey_lengthfor the inner private-key OCTET STRING payload.In the RSA branch, the code then switches back to the outer PKCS#8 buffer and length before deriving RSA attributes and calling
psa_import_key.As a result, RSA-specific parsing receives a
PrivateKeyInfoobject instead of the required innerRSAPrivateKeyDER object.