fix: trace row labels#4443
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
BloggerBust
force-pushed
the
feat/trace-row-labels
branch
from
df9d8cf to
927f693
Compare
Contributor
|
|
The Traces tab showed the raw engine span name on every row, such as hatchet.engine.workflow_run, which a user cannot read. Note: A short run id is appended to workflow-run rows because run display names are not unique across concurrent runs.
Retried tasks render start_step_run span attempts all with the same task name, so the rows were indistinguishable in the trace view. Step-run labels now append the retry number from hatchet.retry_count when it is above zero. I also The queued bar was colored by hasErrorInTree, which walks the subtree, so a successful retry showed red, because the converter nests the failed attempts under the surviving one. isSpanError colors by an engine span's own status and only falls back to the subtree for non-engine spans.
Rows for hatchet.engine.event and hatchet.engine.event_emitted showed the internal span name. They now show the event key, with a short event id appended so rows stay distinct when one task emits the same key more than once.
Replacing span names on engine rows made the trace view inconsistent with how trace tooling labels spans, so the raw span name is back as the primary label on every row. The workflow, task, or event identity now renders in the badge next to it, split into name and discriminator so the short run id, event id, or retry number stays visible when the name truncates. Group headers return to raw span names, and tooltips title the span name with the identity as the subtitle.
BloggerBust
force-pushed
the
feat/trace-row-labels
branch
from
927f693 to
e9f74df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The run trace view labeled engine-generated rows only by their span names, such as
hatchet.engine.workflow_run, so repeated rows were indistinguishable. A user reported this in Discord. The span name stays the primary label, consistent with how trace tools label spans, and each engine row gains a badge with its Hatchet identity. The PR also fixes a queued-bar color bug on retried tasks.Type of change
What's Changed
Checklist
Changes have been:
🤖 AI Disclosure
I acknowledge that an LLM was used in the creation of this Pull Request, in accordance with Hatchet's AI_POLICY.md.
Details: Claude Opus 4.8 (Claude Code) was used for the investigation and writing the unit tests.
Before
After