perf: hot schedulers#4451
Open
grutt wants to merge 6 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Benchmark resultsCompared against |
mrkaye97
reviewed
Jul 16, 2026
| f.uniqueSlots = refs | ||
| f.actionSlotRefs = refs | ||
| if f.uniqueSlots > 0 { | ||
| f.fanout = float64(f.actionSlotRefs) / float64(f.uniqueSlots) |
Contributor
There was a problem hiding this comment.
is this not trivially going to be 1.0 since we're dividing refs by itself?
Member
Author
There was a problem hiding this comment.
lol yes, artifact of the test written on main's code which would not have been 1.
Contributor
There was a problem hiding this comment.
do these tests fail on main?
Member
Author
There was a problem hiding this comment.
i wrote them before making any changes but they require changes on this branch which is bad
Contributor
There was a problem hiding this comment.
I'm not sure I follow? I just ran these tests on main and they all passed, so I'm not convinced they're either 1) not flaky or 2) actually testing anything - I imagine these are supposed to be a regression test?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reworks the v1 scheduler so slot capacity lives in per-worker pools instead of being copied into each action, cutting assignment/replenish overhead on large worker sets. Also fixes unused-slot accounting so expiry cannot make selection skip valid capacity.
Type of change
What's Changed
slotPoolkeyed by worker + slot type; actions keep a thin worker-id indexactive()selection (do not hard-gate onunusedCount, which can drift on expiry)unusedChecklist
Changes have been:
Testing
go test ./pkg/scheduling/v1/ -count=1🤖 AI Disclosure
I acknowledge that an LLM was used in the creation of this Pull Request, in accordance with Hatchet's AI_POLICY.md.
Details: Used cursor throughout investigation and writing the pr