feat(languages): update markdown grammar version#14814
feat(languages): update markdown grammar version#14814RoloEdits wants to merge 2 commits intohelix-editor:masterfrom
Conversation
|
Seems like it is indeed an issue. Any thoughts on how to resolve @the-mikedavis ? |
f749b46 to
d7572d8
Compare
|
Well adding git(&grammar_dir, ["reset", "--hard"])?;
git(&grammar_dir, ["clean", "-fdx"])?;now only has the issue on the test jobs, with check, docs, and lints now passing. If it worked for those not sure why there is still the issue with the test jobs. Is there some CI caching that could be keeping the bad state? Or am I missing something obvious? |
d7572d8 to
e95eeb5
Compare
|
I'm still not sure what was wrong, but I did check, and after the fetch it did indeed say that there was a change to that file, even when nothing was done to it. The normal ways tried above didn't fix it, so now changed to just remove the grammar folder and start fresh when it detects a new revision. I will open a new PR with that fix separately. edit: #14817 |
e95eeb5 to
d1e63bc
Compare
I think you left #14817 in this PR by accident. |
|
I think its worth that being a separate PR (hence both open). I will just rebase this PR on top of master when that (or whatever the fix ultimately is) gets merged as a hacky workaround (I wish github had better support for stacked PRs, but alas). |
d1e63bc to
19126f4
Compare
Updates the markdown and markdown_inline grammar versions.
While updating I did come across a build issue:
I fixed this by deleting the
runtime/grammars/sources/markdown|markdown_inlinefolders. Unsure if this is just a local issue or if this will cause problems with everyone and should be handled more robustly.Fixes: #9678