Improve readability and grammar of workspace trust docs and popup#15636
Improve readability and grammar of workspace trust docs and popup#15636David-Else wants to merge 3 commits intohelix-editor:masterfrom
Conversation
|
See #15531. I was called out on these docs already, that PR was my attempt to fix them. I feel like this feature is pretty simple, and doesn't really require so thorough explanation of it. I would prefer something akin to my patch: that is, more concise. To be exact: you've left the explanation in the beginning about why we are doing this. I don't feel like this is necessary. I don't think explaining 'Never' button is of any use to anyone. Line 9 in your PR. I would also rephrase the paragraph on line 22 in your patch, everything else is fine with me. |
|
@xe-nul I am sorry I didn't see your pull request before I started this one or I would have contributed to that instead. I have made the changes you suggested and made it more concise, I think it is good now, what do you think? I copied your Windows paths but can't validate them as I don't have Windows, I thought Windows had |
|
Yeah, looks good to me now. Windows paths canonically use backslashes instead of regular ones, but I think you can use them interchangeably nowadays. Still, you might want to change them, otherwise someone will be annoyed by it. |
I made improvements to the readability and grammar of the workspace trust docs and popup.
I think in the long run it would benefit from screenshots of the popup dialogue, but I don't think the Helix docs has the capability for that with responsive design requirements.
@xe-nul I hope I have your blessings on this, let me know if I need to make any changes, great job on the workspace trust!