fix(queries:ecma): proper numeric values#15642
Merged
the-mikedavis merged 1 commit intohelix-editor:masterfrom Apr 20, 2026
Merged
fix(queries:ecma): proper numeric values#15642the-mikedavis merged 1 commit intohelix-editor:masterfrom
the-mikedavis merged 1 commit intohelix-editor:masterfrom
Conversation
e724701 to
a38a19c
Compare
the-mikedavis
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#15283 reopened, because the TS org is taking too long.
Unlike the previous PR, I decided to use smaller regexes that assume literals are valid. This makes them much more readable, at the expense of false positives (and a bit of false negatives).
Now everything is
floatunless it's clearly abigintTo test, create a buffer with content:
and use the
zenburntheme, as that theme is the only one that distinguishes the 3 cases by default