feat(landing): enhance layout of trusted by section for improved spacing#21
feat(landing): enhance layout of trusted by section for improved spacing#21hoangsonww merged 1 commit intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary of ChangesHello @hoangsonww, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a minor but impactful UI refinement within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Pull request overview
This PR enhances the spacing in the "Trusted By" section of the landing page by adding a right margin to the label text. The change improves visual separation between the "trustedBy" label and the following brand badges.
Changes:
- Added
mr-2(margin-right) utility class to the "trustedBy" label span element
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <Reveal delay={0.15}> | ||
| <div className="flex flex-wrap items-center gap-4 rounded-2xl border border-border bg-card/70 px-6 py-4 text-sm text-muted-foreground shadow-sm"> | ||
| <span className="font-semibold text-foreground"> | ||
| <span className="font-semibold text-foreground mr-2"> |
There was a problem hiding this comment.
The Tailwind CSS class order is inconsistent with the codebase conventions. In this project, margin classes are consistently placed before text utility classes. The mr-2 class should be positioned before text-foreground to maintain consistency with patterns seen throughout the file (e.g., lines 495, 509, 528, 678, 712 where mt-2 precedes text-related classes).
| <Reveal delay={0.15}> | ||
| <div className="flex flex-wrap items-center gap-4 rounded-2xl border border-border bg-card/70 px-6 py-4 text-sm text-muted-foreground shadow-sm"> | ||
| <span className="font-semibold text-foreground"> | ||
| <span className="font-semibold text-foreground mr-2"> |
There was a problem hiding this comment.
The parent div already has a gap-4 class, which applies a 1rem (16px) gap between its direct children. Adding mr-2 (0.5rem or 8px) to this <span> element will create an additional margin, resulting in a total of 1.5rem (24px) space between the 'trustedBy' label and the subsequent RevealGroup. This might lead to inconsistent spacing, especially since the RevealGroup itself uses gap-3 (0.75rem or 12px) for its internal elements. Consider removing mr-2 and relying solely on the parent's gap-4 for more consistent spacing, or adjust the parent's gap if a different overall spacing is desired for this section.
| <span className="font-semibold text-foreground mr-2"> | |
| <span className="font-semibold text-foreground"> |
This pull request makes a minor adjustment to the layout in the
RealHomecomponent on the homepage. The only change is the addition of a right margin (mr-2) to the "trustedBy" label, which will improve spacing between elements in the UI.