Skip to content

Add watering contours for gardena - #178776

Merged
joostlek merged 2 commits into
home-assistant:devfrom
elupus:gardena/contour-image
Aug 12, 2026
Merged

Add watering contours for gardena#178776
joostlek merged 2 commits into
home-assistant:devfrom
elupus:gardena/contour-image

Conversation

@elupus

@elupus elupus commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Proposed change

Add visualisations of watering contours as image entities as well as the current watering directions. The image will look similar to (although the animation is part of a later library bump):

test_contour_to_svg_snapshot_spraying_within_contour

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant

Copy link
Copy Markdown
Contributor

Hey there @alistair23, mind taking a look at this pull request as it has been labeled with an integration (husqvarna_automower_ble) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of husqvarna_automower_ble can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign husqvarna_automower_ble Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Gardena Bluetooth watering-contour visualizations as SVG image entities.

Changes:

  • Adds stored and active contour image entities.
  • Caches slow segmented contour reads and adds comprehensive tests.
  • Upgrades gardena-bluetooth to 2.10.1.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
homeassistant/components/gardena_bluetooth/__init__.py Enables the image platform.
homeassistant/components/gardena_bluetooth/coordinator.py Caches segmented characteristic reads.
homeassistant/components/gardena_bluetooth/icons.json Adds contour entity icons.
homeassistant/components/gardena_bluetooth/image.py Implements contour SVG image entities.
homeassistant/components/gardena_bluetooth/manifest.json Upgrades the required library.
homeassistant/components/gardena_bluetooth/strings.json Adds image entity translations.
homeassistant/components/husqvarna_automower_ble/manifest.json Aligns the shared dependency version.
requirements_all.txt Updates the consolidated dependency pin.
tests/components/gardena_bluetooth/test_image.py Tests rendering, updates, caching, and failures.
tests/components/gardena_bluetooth/snapshots/test_image.ambr Records image entity and SVG snapshots.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread homeassistant/components/gardena_bluetooth/coordinator.py Outdated
@github-actions

This comment was marked as outdated.

@elupus
elupus force-pushed the gardena/contour-image branch from 792f253 to db0e9da Compare August 11, 2026 22:06
Copilot AI review requested due to automatic review settings August 11, 2026 22:25
@elupus
elupus marked this pull request as ready for review August 11, 2026 22:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

@joostlek
joostlek merged commit b57ed1d into home-assistant:dev Aug 12, 2026
33 checks passed
raman325 added a commit to raman325/home-assistant that referenced this pull request Aug 12, 2026
* upstream/dev: (568 commits)
  Add KNX select entity UI configuration (home-assistant#178282)
  Add send_text service to vizio (home-assistant#176563)
  Add KNX weather entity UI configuration (home-assistant#177186)
  Fix potential race condition in SMTP integration (home-assistant#178416)
  Avoid a naive datetime.now() in switchbot_cloud (home-assistant#178484)
  Avoid a naive datetime.now() in radarr (home-assistant#178487)
  Migrate somfy_mylink to pysomfymylink and adopt integration (home-assistant#176848)
  Nest Netatmo devices under the device they report through (home-assistant#178743)
  Add Monzo transaction events (home-assistant#177397)
  Split user flow init and data submission in nina config flow tests (home-assistant#178992)
  Change energenie key to one without dashes (home-assistant#178931)
  Migrate integrations passing merge parameters to async_update_device (home-assistant#178905)
  Remove unused service timeout in API (home-assistant#172863)
  Add attributes to all template platforms (home-assistant#178762)
  Add new event sensors to Home Connect (home-assistant#178761)
  Fix delayed trains being dropped from Israel Rail departures (home-assistant#178773)
  Fix  missing optional `gameserverip` field in Steam Online dataclass (home-assistant#178751)
  Add watering contours for gardena (home-assistant#178776)
  Add new Hotspring Integration (home-assistant#177992)
  Bump dorny/paths-filter from 4.0.2 to 4.0.3 (home-assistant#178785)
  ...

# Conflicts:
#	homeassistant/components/vizio/__init__.py
#	tests/components/vizio/test_init.py
raman325 added a commit to raman325/home-assistant that referenced this pull request Aug 12, 2026
* upstream/dev: (78 commits)
  Add KNX select entity UI configuration (home-assistant#178282)
  Add send_text service to vizio (home-assistant#176563)
  Add KNX weather entity UI configuration (home-assistant#177186)
  Fix potential race condition in SMTP integration (home-assistant#178416)
  Avoid a naive datetime.now() in switchbot_cloud (home-assistant#178484)
  Avoid a naive datetime.now() in radarr (home-assistant#178487)
  Migrate somfy_mylink to pysomfymylink and adopt integration (home-assistant#176848)
  Nest Netatmo devices under the device they report through (home-assistant#178743)
  Add Monzo transaction events (home-assistant#177397)
  Split user flow init and data submission in nina config flow tests (home-assistant#178992)
  Change energenie key to one without dashes (home-assistant#178931)
  Migrate integrations passing merge parameters to async_update_device (home-assistant#178905)
  Remove unused service timeout in API (home-assistant#172863)
  Add attributes to all template platforms (home-assistant#178762)
  Add new event sensors to Home Connect (home-assistant#178761)
  Fix delayed trains being dropped from Israel Rail departures (home-assistant#178773)
  Fix  missing optional `gameserverip` field in Steam Online dataclass (home-assistant#178751)
  Add watering contours for gardena (home-assistant#178776)
  Add new Hotspring Integration (home-assistant#177992)
  Bump dorny/paths-filter from 4.0.2 to 4.0.3 (home-assistant#178785)
  ...

# Conflicts:
#	tests/components/vizio/test_init.py
raman325 added a commit to raman325/home-assistant that referenced this pull request Aug 12, 2026
* upstream/dev: (78 commits)
  Add KNX select entity UI configuration (home-assistant#178282)
  Add send_text service to vizio (home-assistant#176563)
  Add KNX weather entity UI configuration (home-assistant#177186)
  Fix potential race condition in SMTP integration (home-assistant#178416)
  Avoid a naive datetime.now() in switchbot_cloud (home-assistant#178484)
  Avoid a naive datetime.now() in radarr (home-assistant#178487)
  Migrate somfy_mylink to pysomfymylink and adopt integration (home-assistant#176848)
  Nest Netatmo devices under the device they report through (home-assistant#178743)
  Add Monzo transaction events (home-assistant#177397)
  Split user flow init and data submission in nina config flow tests (home-assistant#178992)
  Change energenie key to one without dashes (home-assistant#178931)
  Migrate integrations passing merge parameters to async_update_device (home-assistant#178905)
  Remove unused service timeout in API (home-assistant#172863)
  Add attributes to all template platforms (home-assistant#178762)
  Add new event sensors to Home Connect (home-assistant#178761)
  Fix delayed trains being dropped from Israel Rail departures (home-assistant#178773)
  Fix  missing optional `gameserverip` field in Steam Online dataclass (home-assistant#178751)
  Add watering contours for gardena (home-assistant#178776)
  Add new Hotspring Integration (home-assistant#177992)
  Bump dorny/paths-filter from 4.0.2 to 4.0.3 (home-assistant#178785)
  ...

# Conflicts:
#	homeassistant/components/vizio/config_flow.py
#	tests/components/vizio/test_config_flow.py
#	tests/components/vizio/test_init.py
@elupus
elupus deleted the gardena/contour-image branch August 12, 2026 15:12
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants