Fix virtual fields on deep projection#18
Closed
cdobre wants to merge 2 commits into
Closed
Conversation
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a custom logical schema adds virtual sub-fields to a struct, their names appeared in projection_deep passed to the Parquet reader. The reader fell back to reading the whole struct (or errored) because the virtual names don't exist in the physical file.
Root cause: scan_plan.parquet_read_schema was derived from the kernel scan which was built with the custom schema, so it also contained virtual sub-fields and could not be used to distinguish physical from virtual. But we can use the
table_config.schemato differentiate between virtual and actual physical fields so we can apply a filter which: