feat: remove string fmt allocation in hot loop in BpeBuilder::build#2010
Merged
ArthurZucker merged 2 commits intomainfrom Apr 10, 2026
Merged
feat: remove string fmt allocation in hot loop in BpeBuilder::build#2010ArthurZucker merged 2 commits intomainfrom
BpeBuilder::build#2010ArthurZucker merged 2 commits intomainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
approved these changes
Apr 8, 2026
Collaborator
|
/benchmark |
Python Benchmark resultsCommit:
|
Rust Benchmark resultsCommit:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
was running samply on
encode_batch_fastand noticed that init was long, so digging deeper found thatBpeBuilder::buildwas doinglet new_token = format!("{}{}", a, &b[prefix_len..]);in a hot loop. Pre-allocating a buffer and writing into it directly resulted in a ~48% perf boost!Test script:
used:
to find & measure the change
Before:

After:

36ms -> 25ms so ~45% faster