Draft
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
- bump tokenizers, bindings/python, bindings/node to 0.23 release versions - commit bindings/python/Cargo.lock - switch bindings/node to yarn.lock (drop package-lock.json) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ArthurZucker
force-pushed
the
v0.23-release
branch
from
6041bb8 to
2a68611
Compare
- swap goto-bus-stop/setup-zig (unmaintained) for mlugg/setup-zig; the former was failing `zig env` on current Ubuntu runners, which napi-rs calls from patchArmFeaturesHForArmTargets for ARM/musl/freebsd cross-compiles. - bump rust inside the x86_64-unknown-linux-gnu docker build: the pinned napi-rs lts-debian image ships Rust 1.82.0, but transitive deps now require edition2024 (Rust 1.85+). `rustup update stable` pulls a current toolchain before invoking `yarn build`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
napi-rs no longer supports FreeBSD under --zig, and cross-compilation via a FreeBSD VM is a separate, slower setup. Drop the target from the build matrix and the napi triples list; FreeBSD users can build from source if needed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
napi-rs's patchArmFeaturesHForArmTargets fails to find zig on PATH under both goto-bus-stop/setup-zig and mlugg/setup-zig on current runners. Skip the target for now to unblock the release; can be revisited with a native ARM runner or a pinned zig version later. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
actions/setup-python is pulling a broken python-3.14.4-win32-arm64- freethreaded package (0-byte python.exe, pip install fails with ModuleNotFoundError: encodings). Upstream breakage in actions/python- versions. Keep the regular 3.14 arm64 build; free-threaded arm64 Windows wheels are extremely niche and can be added back when the upstream package is fixed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@napi-rs/cli removed the --name option; the name is now read from the napi.name field in package.json. Replace with --dir ./artifacts so the command picks up the downloaded per-target .node files. Also pins the second PyO3/maturin-action reference (inside the build job) that was missed by the earlier action-modernization commit. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
napi-rs/cli's `napi universal` subcommand looks up the universal arch entry in the napi.triples config. Without `universal-apple-darwin` in the additional list the command errors with 'universal' arch for platform 'darwin' not found in config! Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
maturin-action v1.51 auto-enables sccache, but inside the manylinux docker containers sccache can't reach the GHA cache service and times out during rustc version detection: sccache: error: Timed out waiting for server startup 💥 maturin failed Disabling sccache restores the pre-v1.51 behaviour. Compilation is slower but correct; if we later want caching for the non-container builds we can switch on/off conditionally via the matrix. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft PR