fix(launcher-standard): replace hard-coded /var/mnt/eclipse/... with a search-ladder#171
Open
hyperpolymath wants to merge 1 commit into
Open
fix(launcher-standard): replace hard-coded /var/mnt/eclipse/... with a search-ladder#171hyperpolymath wants to merge 1 commit into
hyperpolymath wants to merge 1 commit into
Conversation
…a search-ladder The launcher standard previously hard-coded `/var/mnt/eclipse/repos/...` as the sole literal-fallback path for both `launch-scaffolder` finding `launcher-standard.a2ml` and `.desktop` files finding `keepopen.sh` / `verify-desktop-integrity.sh`. On any host that does not happen to use the eclipse-mount layout (e.g. `$HOME/developer/repos`, `$HOME/dev/repos`), the documented default fallback simply pointed at a non-existent path. This blocked anyone outside that one layout from using the standard's defaults — they had to set `--standard <path>` / `$LAUNCH_SCAFFOLDER_STANDARD` on every invocation, and could not rely on the documented `.desktop` templates at all. Changes: - Add `[resolution]` table to `launcher-standard.a2ml` with two search ladders: `desktop-tools-search` (finds `.desktop-tools/`) and `standard-search` (finds `launcher-standard.a2ml`). Each ladder is ordered: explicit env-var override → estate-root → XDG default → three known absolute layouts (eclipse, `$HOME/developer/repos`, `$HOME/dev/repos`). First existing match wins. - Add `launcher/resolve-desktop-tools.sh`: bash reference implementation exposing `hp_resolve_desktop_tools` and `hp_resolve_standard` as sourceable functions, plus CLI behaviour (`--list`, `--standard`, `<tool-name>`). Downstream launchers SHOULD use this rather than re-implement the ladder. - Mark the existing `deployed-symlink` and `fallback-paths` literals DEPRECATED but keep them in place: pre-resolution consumers (`launch-scaffolder` until it's rebuilt against this spec) still read those keys, so removing them would break them. New code MUST use `[resolution]`. - Update `docs/UX-standards/launcher-standard.adoc` §Canonical location to describe the ladder and reference `resolve-desktop-tools.sh`. Also update the `.desktop` Exec= example with an explicit comment that the path is resolved at install time (because the freedesktop spec does not expand env vars in Exec=). - Update `launcher/README.adoc` consumer-resolution-order section to describe the ladder instead of the obsolete single literal. Spec `[spec].version` intentionally NOT bumped here — PR #170 also bumps it (to 0.3.0) and the two PRs are independent off main; whichever merges second will need a trivial conflict-resolve to land both bumps. Verified on this host: $ launcher/resolve-desktop-tools.sh --standard /home/hyperpolymath/developer/repos/standards/launcher/launcher-standard.a2ml (previously: nothing — the only candidate path was the eclipse one) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
🔍 Hypatia Security ScanFindings: 192 issues detected
View findings[
{
"reason": "Action hyperpolymath/standards/.github/workflows/deno-ci-reusable.yml@main needs attention",
"type": "unpinned_action",
"file": "deno-ci-reusable.yml",
"action": "pin_sha",
"rule_module": "workflow_audit",
"severity": "high"
},
{
"reason": "Action hyperpolymath/standards/.github/workflows/governance-reusable.yml@main needs attention",
"type": "unpinned_action",
"file": "governance-reusable.yml",
"action": "pin_sha",
"rule_module": "workflow_audit",
"severity": "high"
},
{
"reason": "Action hyperpolymath/standards/.github/workflows/governance-reusable.yml@main needs attention",
"type": "unpinned_action",
"file": "governance.yml",
"action": "pin_sha",
"rule_module": "workflow_audit",
"severity": "high"
},
{
"reason": "Python file detected -- banned language",
"type": "banned_language_file",
"file": "/home/runner/work/standards/standards/a2ml-templates/state-scm-to-v2.py",
"action": "flag",
"rule_module": "cicd_rules",
"severity": "critical"
},
{
"reason": "TypeScript file detected -- banned language",
"type": "banned_language_file",
"file": "/home/runner/work/standards/standards/a2ml/bindings/deno/mod.ts",
"action": "flag",
"rule_module": "cicd_rules",
"severity": "critical"
},
{
"reason": "TypeScript file detected -- banned language",
"type": "banned_language_file",
"file": "/home/runner/work/standards/standards/lol/test/vitest.config.ts",
"action": "flag",
"rule_module": "cicd_rules",
"severity": "critical"
},
{
"reason": "TypeScript file detected -- banned language",
"type": "banned_language_file",
"file": "/home/runner/work/standards/standards/k9-svc/bindings/deno/mod.ts",
"action": "flag",
"rule_module": "cicd_rules",
"severity": "critical"
},
{
"reason": "Agda postulate assumes without proof -- potential soundness hole (4 occurrences, CWE-704)",
"type": "agda_postulate",
"file": "/home/runner/work/standards/standards/lol/proofs/theories/information_theory.agda",
"action": "flag",
"rule_module": "code_safety",
"severity": "critical"
},
{
"reason": "believe_me undermines formal verification (1 occurrences, CWE-704)",
"type": "believe_me",
"file": "/home/runner/work/standards/standards/lol/src/abi/Locale.idr",
"action": "flag",
"rule_module": "code_safety",
"severity": "critical"
},
{
"reason": "Wildcard CORS -- restrict to specific origins or use env var (1 occurrences, CWE-942)",
"type": "js_wildcard_cors",
"file": "/home/runner/work/standards/standards/consent-aware-http/examples/reference-implementations/deno/aibdp_middleware.js",
"action": "flag",
"rule_module": "code_safety",
"severity": "high"
}
]Powered by Hypatia Neurosymbolic CI/CD Intelligence |
This was referenced May 26, 2026
hyperpolymath
added a commit
that referenced
this pull request
May 26, 2026
…ifest Filed alongside the 8 launcher-standard PRs (#170, #171, #172, #173, #175, #176, #177, #179) so reviewers landing on any individual PR can find the full picture in one place. Two files following the existing `docs/audits/` convention: - launcher-standard-review-2026-05-26.adoc — prose narrative for humans. Headline findings table (class × finding × addressed-in PR), PR map (number, branch, files, class), what-this-campaign-produces summary, deferred follow-ups, method notes including the parallel-session amend incident and how recovery worked. - launcher-standard-review-2026-05-26.a2ml — machine-readable manifest for tooling (PR-batching bots, change-impact analyzers, launch-scaffolder regenerators). Same PR set as parseable A2ML: per-PR file lists, addressed-issues, new-files lists, new-a2ml-keys lists, plus coordination notes (spec-version conflict resolution, lock-step gate trigger map) and deferred-followups with gating conditions. Includes a session-lessons-captured block pointing at the two memory entries written during this campaign. Pattern matches existing gap-matrix-2026-04-17.a2ml (A2ML extension syntax including @abstract: block). Pure tomllib does NOT parse A2ML; the repo's A2ML tooling does. Signing-key fingerprint deliberately NOT recorded inline — gitleaks's generic-api-key rule misclassifies 40-char PGP fingerprints as secrets. The all-prs-gpg-signed flag is the load-bearing assertion; the fingerprint is recoverable from `git log --show-signature` if anyone needs to verify against a specific key. Independent of all 8 review PRs — touches only docs/audits/. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
hyperpolymath
added a commit
that referenced
this pull request
May 26, 2026
…e format (#173) ## Summary The launcher-standard requires `--help` but not `--version`, so launchers had no obligation to emit a version string. Result: field bug reports consistently lack a build identity ("it's broken on my machine" with no SHA, no way to bisect, no way to tell two builds apart). This adds `--version` (and the alias `-V`) to the required meta-modes. The first line of output MUST follow a machine-greppable format: \`\`\` {app-name} {version} ({build-sha-short}) [{platform}] \`\`\` Example: `aerie-launcher 0.4.2 (a1b2c3d) [linux-x86_64]` Additional lines (build date, runtime versions, dep summary) MAY follow. Exit code MUST be 0 on success. ## Changes - **`launcher/launcher-standard.a2ml`**: added `--version` to `[required-modes].meta`; added new `[version-output]` table specifying the first-line format, an example, exit code, and machine-greppable flag. - **`docs/UX-standards/launcher-standard.adoc`**: added a row to the §Required Modes table describing `--version` / `-V`, the format, and the rationale. Both files updated in the same commit per the §Sync requirement and the lock-step CI gate (PR #172) — this PR is a good first live test of that gate. ## Test plan - [x] a2ml parses (python tomllib): `meta = ['--help', '--version']`, `[version-output]` round-trips with all four fields intact. - [x] AsciiDoc table renders (visual — added one row, no structural changes). - [ ] Lock-step gate (#172) goes green on this PR's first push (both files in diff). ## Coordination - Independent of #170, #171, #172. The lock-step gate runs on every PR touching either of the two group files, so this PR will be one of the first live exercises of that gate once #172 lands. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
hyperpolymath
added a commit
that referenced
this pull request
May 26, 2026
…#176) ## Summary `keepopen.sh` always emitted ANSI colour escapes — even when the user redirected output to a file or pipeline, and even when `NO_COLOR=1` was set. [no-color.org](https://no-color.org/) has been the canonical opt-out env var since 2017; respecting it is one of the cheapest UX wins available. ## Change At the top of `keepopen.sh`, if either `NO_COLOR` is set OR stdout is not a TTY, all colour variables become empty strings. Banners and prefix labels become plain text — still loud and clearly labelled, just without escapes. \`\`\`bash if [[ -n "${NO_COLOR:-}" ]] || [[ ! -t 1 ]]; then C_RED='' C_YEL='' C_CYA='' C_GRN='' C_BOLD='' C_RST='' else # original ANSI definitions fi \`\`\` ## Verified \`\`\` $ NO_COLOR=1 keepopen.sh testapp /tmp false false | grep -c $'\033' 0 $ keepopen.sh testapp /tmp false false | grep -c $'\033' # piped → not TTY 0 \`\`\` Desktop-launch path keeps colour (real terminal, no `NO_COLOR`), so the on-screen failure banners are unchanged. The new behaviour only fires when: - User has `NO_COLOR` set globally (their explicit preference), or - Output is piped to a file / capture (CI logs, `tee`, `.log` redirects) ## Scope Touches `launcher/keepopen.sh` only — not part of the a2ml↔adoc lock-step group, so the gate in #172 does not fire on this PR. ## Coordination Independent of all other open launcher-standard PRs (#170, #171, #172, #173, #175) — different file, no conflicts in any merge order. ## Test plan - [x] `NO_COLOR=1` produces zero ANSI escapes - [x] Pipe (non-TTY stdout) produces zero ANSI escapes - [x] Default TTY behaviour unchanged (loud red/yellow banners) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
hyperpolymath
added a commit
that referenced
this pull request
May 26, 2026
…ttack hardening) (#175) ## Summary The launcher-standard specified `/tmp/{app-name}-server.pid` and `/tmp/{app-name}-server.log` as the required runtime paths. Predictable names in a world-writable directory are a **symlink-attack target** on any shared host: - An attacker can pre-create `/tmp/<app>-server.pid` containing their own PID. The launcher's `is_running()` returns true, and `stop_server()` will `kill <attacker-pid>` — DoS or signal-handling abuse. - Similar pattern for the log: pre-symlink `/tmp/<app>-server.log` → some target the attacker wants clobbered, then the launcher's `nohup ... > LOG_FILE` does the write. - The standard already warns "don't log sensitive information" (§Best Practices > Security), but the predictable-path defence is belt-and-braces. ## Fix Route both to XDG dirs with documented fallback ladders: - **PID** → `${XDG_RUNTIME_DIR:-${TMPDIR:-/tmp}}/<app>-server.pid`. `$XDG_RUNTIME_DIR` is mode `0700` and user-scoped per the XDG Base Directory spec (Linux). `$TMPDIR` covers macOS / BSDs (typically `/var/folders/.../T`, per-user). `/tmp` remains only as a last-resort fallback for hosts that set neither (rare). - **Log** → `${XDG_STATE_HOME:-$HOME/.local/state}/<app>/server.log`. Per-user, survives reboot, not world-writable. The `<app>` subdir isolates each launcher's logs. ## Changes Both files in the same commit per the lock-step requirement (and the gate in #172): - **`launcher/launcher-standard.a2ml`** - `[runtime].pid-file-pattern` / `log-file-pattern` updated with fallback ladders + commented rationale - `[disinteg].preserve` updated to reference the new log dir - **`docs/UX-standards/launcher-standard.adoc`** - Standard Launcher Template snippet uses XDG paths + `mkdir -p` for the state dir - §What `--disinteg` removes / does not remove: paths updated - Desktop File `Exec=` example log-arg updated - Calling Convention daemon-chain example updated - Debugging Checklist now uses `$LOG_FILE` / `$PID_FILE` variable refs rather than literal paths - §Best Practices > Logging: lead bullet rewritten with rationale - §Best Practices > Security: new lead bullets explaining the attack vector and the XDG choice - §Compliance Checklist: "Log to predictable location (`/tmp/...`)" replaced with the XDG requirement Remaining `/tmp/` mentions in the prose are in *forbidden-patterns* text that explicitly tells readers NOT to use `/tmp` — intentional. ## Compatibility Bash-expansion syntax (`${VAR:-${VAR2:-/literal}}`) matches the shell-expansion style already in the a2ml (e.g. `$HOME/.local/share/applications` in `[integration.linux]`). Any consumer that already interpolates `$HOME` here will handle `${...:-...}` without changes. Existing launchers that hard-coded `/tmp/<app>-server.pid` continue to work but become non-compliant; no break for them, just a green-field contract change for new launchers and a flagged migration for old ones. ## Coordination - Independent of #170, #171, #172, #173. No file overlap. - Lock-step gate (#172) will go green on first push (both files in diff). ## Notes - Spec `[spec].version` intentionally NOT bumped — five PRs (#170, #171, #173, this one, plus any future) all touch the contract; the merger sequences them. ## Test plan - [x] a2ml parses (python tomllib): new patterns round-trip cleanly, `[disinteg].preserve` reflects the new log path - [x] No `/tmp/` literals remain in non-forbidden-patterns prose (grep verified) - [ ] Live lock-step gate (#172) goes green on first push 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
hyperpolymath
added a commit
that referenced
this pull request
May 26, 2026
…-chain (#179) ## Summary The a2ml declared `[soft-attach]` and `[error-visibility]` contracts but provided no reference implementations. Every downstream launcher had to re-implement the "if-installed-then-invoke" pattern and the GUI dialog ladder — guaranteed drift, and a common reason downstream launchers either skip these features (silent failures stay silent) or implement them inconsistently. This adds two sourceable bash helpers in `launcher/`, mirroring the contract semantics from the a2ml, plus prose with graceful-degradation usage patterns. ## `launcher/gui-error.sh` `hp_gui_error "title" "message"`: | Condition | Behaviour | |-----------|-----------| | Always | Write `[title] message` to stderr | | stderr is TTY or `NO_GUI_ERROR=1` | stderr only, return 0 | | no `\$DISPLAY` and no `\$WAYLAND_DISPLAY` | return 1 (cannot show GUI) | | Else | Try `kdialog → zenity → notify-send → xmessage`; first success wins | Mirrors `[error-visibility].gui-dialog-chain` exactly. Verified locally: `NO_GUI_ERROR=1 ./launcher/gui-error.sh "T" "M"` → stderr "[T] M", exit 0. ## `launcher/soft-attach.sh` Three primitives mirroring the three shapes in `[soft-attach].tools`: \`\`\`bash hp_soft_attach_present "command" # 0 if on PATH hp_soft_attach_run "command line" # run if first token present, silent no-op + 0 if missing hp_soft_attach_event "tool" "event-name" [args] # `tool emit event-name args` if present, silent no-op if missing \`\`\` All non-fatal — missing tools never break the launcher (per the §soft-attach spec: *"called if present, silently skipped if absent"*). CLI mode for ad-hoc use: \`\`\` ./soft-attach.sh run "hypatia diagnose --app foo" ./soft-attach.sh event feedback-o-tron launcher:start_failed ./soft-attach.sh present hypatia \`\`\` ## a2ml contract additions `[error-visibility]`: - `reference-impl = "launcher/gui-error.sh"` (pointer) - `suppress-env-var = "NO_GUI_ERROR"` (formalises the override name) `[soft-attach]`: - `reference-impl = "launcher/soft-attach.sh"` (pointer) - Each `tools` entry now carries explicit `style` (`"event" | "command"`) and `trigger` (e.g. `"on-start-failed"`) so launchers know **WHEN** to invoke each tool, not just **HOW**. Previously only `feedback-o-tron` had an explicit failure trigger. ## Prose additions (`launcher-standard.adoc`) - §Error Handling: rewritten with `hp_gui_error` integration, graceful degradation pattern, and a NOTE on stderr-always behaviour - §Soft-Attach (new subsection): documents the three primitives, the graceful-degradation source pattern, and an example `on_start_failed` hook wiring all three default tools ## Test plan - [x] a2ml parses (python tomllib); new fields round-trip cleanly - [x] Both helpers pass `bash -n` - [x] `hp_gui_error` writes stderr + respects `NO_GUI_ERROR` - [x] `hp_soft_attach_present` returns 0/1 correctly - [x] `hp_soft_attach_run` runs installed, silently skips missing - [x] `hp_soft_attach_event` silently skips missing tool - [ ] Manual dialog test (deferred — requires KDE/GNOME desktop; logic matches well-documented invocation conventions per each dialog's man page) - [ ] Lock-step gate (#172) goes green on first push (both files in diff) ## Coordination Independent of #170, #171, #172, #173, #175, #176, #177 — no file overlap. Builds on the resolution ladder shipped in #171 (`hp_resolve_desktop_tools` is referenced in the prose examples) so the new helpers are findable wherever `.desktop-tools/` resolves. Both work standalone or via the ladder. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
hyperpolymath
added a commit
that referenced
this pull request
May 26, 2026
## Summary `launcher/README.adoc` §Sync requirement declares that the machine-readable form (`launcher/launcher-standard.a2ml`) and the prose form (`docs/UX-standards/launcher-standard.adoc`) MUST be edited in the same PR, and calls drift between them a *"standards-compliance bug"* — but nothing enforced the rule. The recently-fixed cross-doc contradictions in [#170](#170) were exactly the drift this rule was meant to prevent. This adds `.github/workflows/launcher-standard-lockstep.yml` — a hard gate that runs on every PR touching either file. If only one is in the diff, it fails with a message naming the missing partner and pointing back at §Sync requirement. ## How it works \`\`\`yaml on: pull_request: paths: - 'launcher/launcher-standard.a2ml' - 'docs/UX-standards/launcher-standard.adoc' \`\`\` GitHub's `paths:` filter ensures the workflow only triggers when one of the two files is touched (cheap — no wasted runs for unrelated PRs). Inside the job, a 30-line bash check diffs `pull_request.base.sha` against `pull_request.head.sha`, computes which of the two files are *touched* vs *missing*, and fails iff the touched set is non-empty but incomplete. ## Dry-run verification Logic dry-run locally against six synthetic diffs: | Diff | Expected | Result | |------|----------|--------| | only a2ml touched | FAIL — drift | FAIL ✓ | | only adoc touched | FAIL — drift | FAIL ✓ | | both touched | PASS | PASS ✓ | | both touched + unrelated | PASS | PASS ✓ | | neither touched | skip (no trigger) | workflow doesn't run ✓ | | a2ml + unrelated (drift) | FAIL — drift | FAIL ✓ | ## Pattern conformance Modelled on the existing `makefile-blocker.yml` gate: - Same SPDX header. - Same `actions/checkout@de0fac2…` pin (verified live against `github.com/actions/checkout` — corresponds to v4 commit `de0fac2e4500dabe0009e67214ff5f5447ce83dd` "Fix tag handling" #2356). - Same `concurrency` block that cancels superseded runs (safe — this is a read-only check, no mutations). - Same `permissions: contents: read`. ## Scope notes - **Initial group is the 2-file pair** the README literally calls out. Once [#171](#171) lands and introduces `launcher/resolve-desktop-tools.sh`, a follow-up should extend the group to include the resolver (which mirrors `[resolution]` in the a2ml and currently relies on reviewer discipline). - **Hard fail, not warning.** The README uses "MUST" / "is a bug" language; the gate matches that strictness. Genuinely one-sided edits (e.g. a prose-only typo fix with no a2ml equivalent) need a no-op whitespace touch to the other file — the error message documents this escape. - **Not added to required-checks list.** Branch-protection config lives outside the repo. Owner can promote this to a required check via the UI or `.github/settings.yml` once they've seen it pass green on a few PRs. ## Coordination - Fully independent of #170 and #171 — touches a different file (`.github/workflows/launcher-standard-lockstep.yml`). No conflicts in any merge order. ## Test plan - [x] Dry-run against 6 synthetic diff scenarios — all expected outcomes - [x] actions/checkout SHA pin verified live - [x] YAML syntactically valid (workflow loads — visible in Actions tab once branch is pushed) - [ ] First live trigger will happen when PR #170 or #171 next pushes and touches a group file — at that point this gate's run will appear on those PRs 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
hyperpolymath
added a commit
that referenced
this pull request
May 26, 2026
…ifest (#182) ## Summary Documentation companion to the 8 launcher-standard PRs filed today (#170, #171, #172, #173, #175, #176, #177, #179). Two files following the existing `docs/audits/` convention: | File | Audience | Purpose | |------|----------|---------| | `launcher-standard-review-2026-05-26.adoc` | Humans | Prose narrative — headline findings table (class × finding × addressed-in PR), full PR map, what-this-campaign-produces summary, deferred follow-ups, method notes | | `launcher-standard-review-2026-05-26.a2ml` | Machines | Parseable manifest — per-PR file lists, addressed-issues, new-files, new-a2ml-keys, coordination notes (spec-version conflict resolution, lock-step gate trigger map), deferred-followups with gating conditions | Reviewers landing on any individual PR can find the full picture in one place. ## Why this exists After 8 PRs the campaign story is spread across 8 PR bodies and 8 commit messages. Without a single landing-page document: - A reviewer landing on, say, PR #175 has no easy way to see that it's part of a larger coordinated change set, or that the `[spec].version` bump conflicts with PR #170's bump. - Tooling (PR-batching bots, change-impact analyzers, launch-scaffolder regenerators) has nothing to introspect; each bot would have to re-parse 8 PR descriptions. - Future audits need an entry point — `docs/audits/` already follows the dated-audit pattern (`dogfooding-matrix-2026-04-04.md`, `gap-matrix-2026-04-17.a2ml`); this matches. ## Pattern conformance - Files in `docs/audits/` matches the existing convention. - A2ML extension syntax (`@abstract:` block) matches `gap-matrix-2026-04-17.a2ml`. Pure `tomllib` does not parse A2ML; the repo's A2ML tooling does. - SPDX headers on both files. ## Coordination - Independent of the 8 review PRs — touches only `docs/audits/`, no overlap with `launcher/` or `docs/UX-standards/`. - Lock-step gate (#172) does NOT fire on this PR (touches neither `launcher-standard.a2ml` nor `launcher-standard.adoc`). - Final PR in the campaign. After this lands, the campaign is fully documented and merge-sequenceable purely from `main` artefacts. ## Test plan - [x] adoc structure: 7 top-level sections (`==`) render under `asciidoctor` (visual) - [x] a2ml structure: 8 `[[pr]]` array entries, `[campaign]`, `[coordination]`, `[deferred-followups]` with 2 `[[deferred]]` items, `[session-lessons-captured]`, `[provenance]` — all present and consistent - [x] All 8 PR numbers in the manifest match the actually-filed PRs 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The launcher standard previously hard-coded
/var/mnt/eclipse/repos/...as the sole literal-fallback path for:
launch-scaffolderfindinglauncher-standard.a2ml.desktopfiles findingkeepopen.sh--integfindingverify-desktop-integrity.shOn any host that doesn't use the eclipse-mount layout (e.g. this one —
/home/hyperpolymath/developer/repos/), the documented default fallbackpointed at a non-existent path. The standard's defaults did not work.
This blocked anyone outside that one layout from using the documented
templates: they had to set
--standard <path>/\$LAUNCH_SCAFFOLDER_STANDARDon every invocation, and could not rely on the documented
.desktoptemplates at all.
What changed
[resolution]table added tolauncher-standard.a2mlwith twosearch ladders —
desktop-tools-search(finds.desktop-tools/)and
standard-search(finds the spec itself). Each ladder is ordered:explicit env-var override → estate-root → XDG default → three known
absolute layouts (eclipse,
\$HOME/developer/repos,\$HOME/dev/repos).First existing match wins.
launcher/resolve-desktop-tools.shadded — bash referenceimplementation of both ladders, exposing
hp_resolve_desktop_toolsand
hp_resolve_standardas sourceable functions, plus a small CLI(
--list,--standard,<tool-name>). Downstream launchers SHOULDuse this rather than re-implementing the ladder.
deployed-symlinkandfallback-pathsliterals kept butmarked DEPRECATED. Removing them would break
launch-scaffolderuntil it's rebuilt against the new spec; the deprecation marker is
the migration signal.
launcher-standard.adoc§Canonical locationdescribes the ladder + references
resolve-desktop-tools.sh; the.desktopExec=example carries a comment that the path isresolved at install time (because the freedesktop spec does NOT
expand env vars in
Exec=lines).launcher/README.adocconsumer-resolution-order section updatedto describe the ladder instead of the obsolete single literal.
Verified on this host
```
$ launcher/resolve-desktop-tools.sh --standard
/home/hyperpolymath/developer/repos/standards/launcher/launcher-standard.a2ml
```
(previously: nothing — the only candidate path was the eclipse one)
a2ml parses clean (verified with python tomllib): 13 top-level tables,
resolution.desktop-tools-searchhas 6 entries,resolution.standard-searchhas 5.Coordination
[spec].version. I deliberately did NOT bump version here; whichever PR merges second needs a trivial conflict-resolve to land both bumps (suggested: fix(launcher-standard): resolve 3 cross-doc contradictions #170 → 0.3.0, this → 0.4.0).launch-scaffolder(separate repo): replace the single hard-coded fallback in its Rust loader with the[resolution].standard-searchladder. Until that lands, this PR is documentation-and-helper only for that consumer — but it already unblocks any new launcher that sourcesresolve-desktop-tools.sh.Out of scope (still deferred from the original review)
open, WSLwslview,\$BROWSER.wait_for_serverignores thewait-for-url-timeout-secondsconstant./tmp/names (XDG hygiene).keepopen.shdoesn't honourNO_COLOR.--versionmode missing from required-modes.[soft-attach]/gui-dialog-chainlack reference impls.Test plan
resolve-desktop-tools.sh --standardfinds the spec on this hostresolve-desktop-tools.sh --listshows the full ladderresolve-desktop-tools.sh keepopen.shcorrectly returns exit 1 when no.desktop-tools/is deployed (expected — that's a separate integration step)launch-scaffolderrebuild picks up the new ladder (separate repo)🤖 Generated with Claude Code