Skip to content

build: add type declarations to /dist #517 - #518

Open
namack wants to merge 1 commit into
imgix:mainfrom
namack:specify-types
Open

build: add type declarations to /dist #517#518
namack wants to merge 1 commit into
imgix:mainfrom
namack:specify-types

Conversation

@namack

@namack namack commented Dec 14, 2023

Copy link
Copy Markdown

Closes #517

Description

This change includes the type declaration file in /dist.

Before this PR, typescript users did not have automatic type inference.

After this PR, typescript users will have automatic type inference.

Checklist

@namack
namack requested a review from a team as a code owner December 14, 2023 19:38
@namack

namack commented Dec 14, 2023

Copy link
Copy Markdown
Author

@luqven One thing I was unsure of was including the /dist/imgix-vue.min.d.ts file in the git history to be included in the release for distribution. I didn't see any un-ignoring of the current build files in /dist in .gitignore, however I am not familiar with this distribution method.

@luqven

luqven commented Dec 14, 2023

Copy link
Copy Markdown
Contributor

@luqven One thing I was unsure of was including the /dist/imgix-vue.min.d.ts file in the git history to be included in the release for distribution. I didn't see any un-ignoring of the current build files in /dist in .gitignore, however I am not familiar with this distribution method.

Semantic-Release should commit that to /dist for us ✅

@namack

namack commented Dec 15, 2023

Copy link
Copy Markdown
Author

Ah great, that's what I was hoping for. Let me know if there's anything else I can do to get this over the line. Looks like CI ran into an issue with the github auth token.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build: add type declarations to /dist

2 participants