Skip to content

refactor: remove identity.rs logic from validate_credential_jwt#124

Open
Oran-Dan wants to merge 4 commits into
devfrom
refactor/validate_credential_jwt
Open

refactor: remove identity.rs logic from validate_credential_jwt#124
Oran-Dan wants to merge 4 commits into
devfrom
refactor/validate_credential_jwt

Conversation

@Oran-Dan
Copy link
Copy Markdown
Contributor

@Oran-Dan Oran-Dan commented Apr 22, 2026

Description of change

BLOCKER: discuss whether we should issue OBv3 as jwt_vc_json in the first place.

The validator from identity.rs only allows for VC 1.1 based credentials. We need to issue VC 2.0 based credentials as well.

Links to any relevant issues

How the change has been tested

Old tests still pass, since it's a refactor no new tests are needed.

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Oran-Dan Oran-Dan self-assigned this Apr 22, 2026
Comment thread oid4vc-core/src/jwt.rs
Comment thread oid4vc-core/src/jwt.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants