refactor: remove identity.rs logic from validate_credential_jwt#124
Open
Oran-Dan wants to merge 4 commits into
Open
refactor: remove identity.rs logic from validate_credential_jwt#124Oran-Dan wants to merge 4 commits into
Oran-Dan wants to merge 4 commits into
Conversation
coplat
reviewed
Apr 23, 2026
coplat
reviewed
Apr 23, 2026
coplat
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
BLOCKER: discuss whether we should issue OBv3 as
jwt_vc_jsonin the first place.The validator from identity.rs only allows for VC 1.1 based credentials. We need to issue VC 2.0 based credentials as well.
Links to any relevant issues
How the change has been tested
Old tests still pass, since it's a refactor no new tests are needed.
Definition of Done checklist
Add an
xto the boxes that are relevant to your changes.