[SPIR-V] Reland "Translate icmp eq and icmp ne to PtrEqual and PtrNotEqual"#22117
Open
vmaksimo wants to merge 2 commits into
Open
[SPIR-V] Reland "Translate icmp eq and icmp ne to PtrEqual and PtrNotEqual"#22117vmaksimo wants to merge 2 commits into
vmaksimo wants to merge 2 commits into
Conversation
…Equal" Reapplies the LLVM-to-SPIR-V translation of pointer icmp eq/ne to OpPtrEqual / OpPtrNotEqual when SPIR-V 1.4 is allowed. The change was reverted in c4be885 due to a batch of SYCL E2E failures. The drivers are now expected to support these opcodes.
Restore the original OpPtrEqual CHECK lines in addrspacecast_null.ll and addrspacecast_generic_null.ll that were temporarily replaced with ConvertPtrToU + IEqual.
Contributor
Author
|
CI failures on Windows look unrelated to the change: Adapters - filed a bug 22151 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reapplies the LLVM-to-SPIR-V translation of pointer
icmp eq/icmp netoOpPtrEqual/OpPtrNotEqualwhen SPIR-V 1.4 is allowed.Original Khronos PR: KhronosGroup/SPIRV-LLVM-Translator#2511
The change was reverted in c4be885 due to a batch of SYCL E2E failures. The drivers are now expected to support these opcodes; CI on this PR validates that assumption.
It resolves p.6 of #7592 "Following patches are missing" section.