[UR/offload] Change CUDA package to CUDAToolkit in CMakeLists.txt#22140
Open
Emimendoza wants to merge 1 commit into
Open
[UR/offload] Change CUDA package to CUDAToolkit in CMakeLists.txt#22140Emimendoza wants to merge 1 commit into
Emimendoza wants to merge 1 commit into
Conversation
FindCUDA has been deprecated (CMP0146) Also the CUDAToolkit package defines CUDAToolkit_INCLUDE_DIRS, the CUDA package doesn't. This fixes a bug in which the UR offload adapter will fail to compile if the cuda adapter is not built alongside it since the cuda.h cannot be found (because CUDAToolkit_INCLUDE_DIRS is not set by the CUDA package) when compiling offload/program.cpp. UR_CUDA_ENABLED is still set because CUDA_cuda_driver_LIBRARY is still set by the CUDA package.
pbalcer
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FindCUDA has been deprecated (CMP0146)
Also the CUDAToolkit package defines CUDAToolkit_INCLUDE_DIRS, the CUDA package doesn't.
This fixes a bug in which the UR offload adapter will fail to compile if the cuda adapter is not built alongside it since the cuda.h cannot be found (because CUDAToolkit_INCLUDE_DIRS is not set by the CUDA package) when compiling offload/program.cpp. UR_CUDA_ENABLED is still set because CUDA_cuda_driver_LIBRARY is still set by the CUDA package.