[SYCL] Add compatible targets to -fsycl-targets#22170
Open
KornevNikita wants to merge 1 commit into
Open
Conversation
Add bmg, dg2, mtl and ptl targets.
Contributor
dm-vodopyanov
left a comment
dm-vodopyanov
left a comment
There was a problem hiding this comment.
LGTM, can we add some E2E tests?
Contributor
Author
Sure, but I'd say it looks excessive, like in the test we see that clang generates the ocloc call with the right @sarnex btw do we have MTL/PTL runners? |
Contributor
|
no only ARL i think |
Contributor
The idea is to check that these binaries generated by compatible targets work fine in run time on at least 2 compatible HW. It is ok to check that in internal CI as well where we have more HW |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add bmg, dg2, mtl and ptl targets.