Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
handleBehavioronion-modaldefaults to"none". For sheet modals that show a handle, the handle is purely decorative: it is not focusable, it is skipped in the tab order, and activating it does nothing. Keyboard and screen reader users cannot resize the sheet unless the developer explicitly opts in withhandleBehavior="cycle".What is the new behavior?
handleBehaviornow defaults to"cycle".handleBehaviorproperty documentation to lead with what each value does and how"cycle"helps accessibility, improving findability and learnability.handleBehavior="none"to restore the previous decorative handle.Does this introduce a breaking change?
This changes the default interaction and focus behavior of sheet modals that use a handle. The handle becomes focusable and enters the tab order, and activating it now cycles breakpoints where it previously did nothing. Sheet modals that relied on the handle being inert should set
handle-behavior="none":Other information
Preview