fix(react): remove relocated inline overlays orphaned on unmount#31223
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Currently, when an inline overlay (
ion-modal,ion-popover) is rendered through React andCoreDelegateteleports its host out of the React-rendered location, unmounting the component can leave the host orphaned in the DOM.componentWillUnmountonly recovered a relocated host whenthis.state.isOpenwastrue, so a host that was moved while still closed was never reattached for React to remove. That happens during the React 18 StrictMode mount/unmount cycle, or any re-render before the present events flipisOpen. The result is duplicate<ion-modal>elements stacking up indocument.body. This came from the portal change in #31159What is the new behavior?
This splits the unmount cleanup into two independent steps. The DOM recovery now runs whenever the host is still connected and has been relocated, regardless of open state: portaled overlays get reattached to
portalTargetso React'sremoveChildcan find them, and nested overlays moved out of their<template>are removed directly. The dismiss-lifecycle teardown, detaching thedidDismisslistener and props, stays gated onisOpenas before. So a relocated-but-closed host is now cleaned up instead of orphaned.Does this introduce a breaking change?
Other information