This repository was archived by the owner on Aug 23, 2020. It is now read-only.
Flush column family#1682
Open
GalRogozinski wants to merge 4 commits intoiotaledger-archive:devfrom
Open
Conversation
added 3 commits
December 9, 2019 11:42
karimodm
approved these changes
Dec 9, 2019
Contributor
karimodm
left a comment
There was a problem hiding this comment.
Alright, this PR will specifically fix the OOMs caused by:
if (configuration.isRevalidate()) {
tangle.clearColumn(com.iota.iri.model.persistables.Milestone.class);
tangle.clearColumn(com.iota.iri.model.StateDiff.class);
tangle.clearMetadata(com.iota.iri.model.persistables.Transaction.class);
Let's go ahead and merge
Contributor
Author
|
@karimodm |
Contributor
Author
|
@karimodm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Delete column family correctly
Fixes #1482
Type of change
How Has This Been Tested?
Ran on dry with
rescanWill be farther validated by the reviewer
Checklist: