Open
Conversation
new-issue urls were cut from the end at 1999 chars, hiding the real cause when daemon migration logs are wrapped in new Error(logs) (see #3147 where fs-repo-12-to-13/ve... were the last visible bytes). truncate by keeping head and tail with a marker between, and raise the url cap to 8000 chars; empirical github nginx ceiling is 8191. - src/dialogs/errors.js: head+tail stack truncation, MAX_URL_LENGTH 8000, encodeURIComponent for query values, fix issueTitle when stack has no newline - test/unit/errors.spec.js: cover length cap, tail preservation, truncation marker, faq routing, special-char encoding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new-issue urls were cut from the end at 1999 chars, hiding the real cause when daemon migration logs are wrapped in
new Error(logs)(see #3147 wherefs-repo-12-to-13/ve... were the last visible bytes).this PR truncates smarter by keeping head and tail with a marker between, and raise the url cap to 8000 chars; confirmed this works in both Firefox and Chrome, and that empirical github server ceiling is 8191.