Skip to content

Rename Lightwheel - #225

Merged
mingxin-zheng merged 2 commits into
mainfrom
mingxue/Modify_docs
Apr 2, 2026
Merged

Rename Lightwheel#225
mingxin-zheng merged 2 commits into
mainfrom
mingxue/Modify_docs

Conversation

@mingxueg-nv

Copy link
Copy Markdown
Contributor

Fixes #ISSUE_NUMBER

Rename LightWheel to Lightwheel

@greptile-apps

greptile-apps Bot commented Apr 2, 2026

Copy link
Copy Markdown

Greptile Summary

This PR performs a brand name correction — "LightWheel" → "Lightwheel" (lowercase 'w') — in the README display text and a single inline comment in assets.py. The actual S3 URL path segments (Props/LightWheel/…) are intentionally left unchanged, so no asset loading is affected by this diff.

Confidence Score: 5/5

Safe to merge — only documentation text and a code comment were changed; no functional code was altered.

Both changed lines are purely cosmetic (README prose and a Python comment). The S3 URL paths that drive actual asset loading remain untouched, so there is no runtime risk introduced by this PR. No P0/P1 findings remain.

No files require special attention.

Important Files Changed

Filename Overview
workflows/rheo/README.md Single-word rename of "LightWheel" → "Lightwheel" in the SimReady Assets section; purely cosmetic documentation change.
workflows/rheo/scripts/simulation/assets/assets.py Only the inline comment "# Props Powered by LightWheel" was updated to "Lightwheel"; all S3 URL path segments (Props/LightWheel/…) remain unchanged, keeping the actual asset URLs intact.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[PR: Rename LightWheel → Lightwheel] --> B[README.md]
    A --> C[assets.py]
    B --> D["Display text updated\n'LightWheel' → 'Lightwheel'"]
    C --> E["Comment updated\n'# Props Powered by LightWheel'\n→ '# Props Powered by Lightwheel'"]
    C --> F["S3 URL paths unchanged\nProps/LightWheel/... retained"]
    F --> G["Assets still resolve\nto existing S3 objects"]
Loading

Reviews (2): Last reviewed commit: "Revert S3 assets path" | Re-trigger Greptile

Comment on lines +20 to +50
@@ -28,23 +28,23 @@
# Props
SCISSORS_USD = ASSET_PATH + "Props/SurgicalInstruments/SurgicalScissors.usd"

# Props Powered by LightWheel
# Props Powered by Lightwheel
# Please be noted that these assets are under Attribution-NonCommercial 4.0 International License.
# Check the license details by replacing the usd file base name with "LICENSE.txt"

PLATE_USD = ASSET_PATH + "Props/LightWheel/Assets/Plate001/plate001.usd"
TROCAR_USD = ASSET_PATH + "Props/LightWheel/Assets/Trocar002/Trocar002.usd"
TROCAR_XFORM_WO_USD = ASSET_PATH + "Props/LightWheel/Assets/Trocar002/Trocar002-xform-wo.usd"
NEEDLE_USD = ASSET_PATH + "Props/LightWheel/Assets/PneumoperitoneumNeedle001/PneumoperitoneumNeedle001.usd"
PUNCTURE_DEVICE_USD = ASSET_PATH + "Props/LightWheel/Assets/PunctureDevice002/PunctureDevice002.usd"
PLATE_USD = ASSET_PATH + "Props/Lightwheel/Assets/Plate001/plate001.usd"
TROCAR_USD = ASSET_PATH + "Props/Lightwheel/Assets/Trocar002/Trocar002.usd"
TROCAR_XFORM_WO_USD = ASSET_PATH + "Props/Lightwheel/Assets/Trocar002/Trocar002-xform-wo.usd"
NEEDLE_USD = ASSET_PATH + "Props/Lightwheel/Assets/PneumoperitoneumNeedle001/PneumoperitoneumNeedle001.usd"
PUNCTURE_DEVICE_USD = ASSET_PATH + "Props/Lightwheel/Assets/PunctureDevice002/PunctureDevice002.usd"
PUNCTURE_DEVICE_XFORM_USD = (
ASSET_PATH
+ "Props/LightWheel/Assets/DisposableLaparoscopicPunctureDevice001/DisposableLaparoscopicPunctureDevice005-xform.usd" # noqa: E501
+ "Props/Lightwheel/Assets/DisposableLaparoscopicPunctureDevice001/DisposableLaparoscopicPunctureDevice005-xform.usd" # noqa: E501
)
TUBE_USD = ASSET_PATH + "Props/LightWheel/Assets/DrainageTube002/DrainageTube003.usd"
TUBE_USD = ASSET_PATH + "Props/Lightwheel/Assets/DrainageTube002/DrainageTube003.usd"

TWEEZERS_USD = ASSET_PATH + "Props/LightWheel/Assets/SurgicalTweezers/AngledTweezers001.usd"
TRAY_USD = ASSET_PATH + "Props/LightWheel/Assets/SurgicalTray006/SurgicalTray006.usd"
TRAY_NO_LID_USD = ASSET_PATH + "Props/LightWheel/Assets/SurgicalTrayNoLid006/SurgicalTrayNoLid006.usd"
TRAY_TROCAR_ASSEMBLY_USD = ASSET_PATH + "Props/LightWheel/Assets/SurgicalTray001/SurgicalTray001.usd"
CART_USD = ASSET_PATH + "Props/LightWheel/Assets/Cart003/Cart003.usd"
TWEEZERS_USD = ASSET_PATH + "Props/Lightwheel/Assets/SurgicalTweezers/AngledTweezers001.usd"
TRAY_USD = ASSET_PATH + "Props/Lightwheel/Assets/SurgicalTray006/SurgicalTray006.usd"
TRAY_NO_LID_USD = ASSET_PATH + "Props/Lightwheel/Assets/SurgicalTrayNoLid006/SurgicalTrayNoLid006.usd"
TRAY_TROCAR_ASSEMBLY_USD = ASSET_PATH + "Props/Lightwheel/Assets/SurgicalTray001/SurgicalTray001.usd"
CART_USD = ASSET_PATH + "Props/Lightwheel/Assets/Cart003/Cart003.usd"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 S3 path case-sensitivity may break asset loading

AWS S3 object keys are case-sensitive. Renaming the URL path segment from Props/LightWheel/ to Props/Lightwheel/ will return HTTP 403/404 for every asset unless the objects in the omniverse-content-production S3 bucket have already been moved or re-keyed to match the new casing. Please confirm the S3-side paths have been updated before merging, or these asset URLs will silently fail at runtime.

Comment thread workflows/rheo/scripts/simulation/assets/assets.py Outdated
@mingxin-zheng
mingxin-zheng merged commit cb51429 into main Apr 2, 2026
3 checks passed
@mingxin-zheng
mingxin-zheng deleted the mingxue/Modify_docs branch April 2, 2026 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants