Rename Lightwheel - #225
Conversation
Greptile SummaryThis PR performs a brand name correction — "LightWheel" → "Lightwheel" (lowercase 'w') — in the README display text and a single inline comment in Confidence Score: 5/5Safe to merge — only documentation text and a code comment were changed; no functional code was altered. Both changed lines are purely cosmetic (README prose and a Python comment). The S3 URL paths that drive actual asset loading remain untouched, so there is no runtime risk introduced by this PR. No P0/P1 findings remain. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[PR: Rename LightWheel → Lightwheel] --> B[README.md]
A --> C[assets.py]
B --> D["Display text updated\n'LightWheel' → 'Lightwheel'"]
C --> E["Comment updated\n'# Props Powered by LightWheel'\n→ '# Props Powered by Lightwheel'"]
C --> F["S3 URL paths unchanged\nProps/LightWheel/... retained"]
F --> G["Assets still resolve\nto existing S3 objects"]
Reviews (2): Last reviewed commit: "Revert S3 assets path" | Re-trigger Greptile |
| @@ -28,23 +28,23 @@ | |||
| # Props | |||
| SCISSORS_USD = ASSET_PATH + "Props/SurgicalInstruments/SurgicalScissors.usd" | |||
|
|
|||
| # Props Powered by LightWheel | |||
| # Props Powered by Lightwheel | |||
| # Please be noted that these assets are under Attribution-NonCommercial 4.0 International License. | |||
| # Check the license details by replacing the usd file base name with "LICENSE.txt" | |||
|
|
|||
| PLATE_USD = ASSET_PATH + "Props/LightWheel/Assets/Plate001/plate001.usd" | |||
| TROCAR_USD = ASSET_PATH + "Props/LightWheel/Assets/Trocar002/Trocar002.usd" | |||
| TROCAR_XFORM_WO_USD = ASSET_PATH + "Props/LightWheel/Assets/Trocar002/Trocar002-xform-wo.usd" | |||
| NEEDLE_USD = ASSET_PATH + "Props/LightWheel/Assets/PneumoperitoneumNeedle001/PneumoperitoneumNeedle001.usd" | |||
| PUNCTURE_DEVICE_USD = ASSET_PATH + "Props/LightWheel/Assets/PunctureDevice002/PunctureDevice002.usd" | |||
| PLATE_USD = ASSET_PATH + "Props/Lightwheel/Assets/Plate001/plate001.usd" | |||
| TROCAR_USD = ASSET_PATH + "Props/Lightwheel/Assets/Trocar002/Trocar002.usd" | |||
| TROCAR_XFORM_WO_USD = ASSET_PATH + "Props/Lightwheel/Assets/Trocar002/Trocar002-xform-wo.usd" | |||
| NEEDLE_USD = ASSET_PATH + "Props/Lightwheel/Assets/PneumoperitoneumNeedle001/PneumoperitoneumNeedle001.usd" | |||
| PUNCTURE_DEVICE_USD = ASSET_PATH + "Props/Lightwheel/Assets/PunctureDevice002/PunctureDevice002.usd" | |||
| PUNCTURE_DEVICE_XFORM_USD = ( | |||
| ASSET_PATH | |||
| + "Props/LightWheel/Assets/DisposableLaparoscopicPunctureDevice001/DisposableLaparoscopicPunctureDevice005-xform.usd" # noqa: E501 | |||
| + "Props/Lightwheel/Assets/DisposableLaparoscopicPunctureDevice001/DisposableLaparoscopicPunctureDevice005-xform.usd" # noqa: E501 | |||
| ) | |||
| TUBE_USD = ASSET_PATH + "Props/LightWheel/Assets/DrainageTube002/DrainageTube003.usd" | |||
| TUBE_USD = ASSET_PATH + "Props/Lightwheel/Assets/DrainageTube002/DrainageTube003.usd" | |||
|
|
|||
| TWEEZERS_USD = ASSET_PATH + "Props/LightWheel/Assets/SurgicalTweezers/AngledTweezers001.usd" | |||
| TRAY_USD = ASSET_PATH + "Props/LightWheel/Assets/SurgicalTray006/SurgicalTray006.usd" | |||
| TRAY_NO_LID_USD = ASSET_PATH + "Props/LightWheel/Assets/SurgicalTrayNoLid006/SurgicalTrayNoLid006.usd" | |||
| TRAY_TROCAR_ASSEMBLY_USD = ASSET_PATH + "Props/LightWheel/Assets/SurgicalTray001/SurgicalTray001.usd" | |||
| CART_USD = ASSET_PATH + "Props/LightWheel/Assets/Cart003/Cart003.usd" | |||
| TWEEZERS_USD = ASSET_PATH + "Props/Lightwheel/Assets/SurgicalTweezers/AngledTweezers001.usd" | |||
| TRAY_USD = ASSET_PATH + "Props/Lightwheel/Assets/SurgicalTray006/SurgicalTray006.usd" | |||
| TRAY_NO_LID_USD = ASSET_PATH + "Props/Lightwheel/Assets/SurgicalTrayNoLid006/SurgicalTrayNoLid006.usd" | |||
| TRAY_TROCAR_ASSEMBLY_USD = ASSET_PATH + "Props/Lightwheel/Assets/SurgicalTray001/SurgicalTray001.usd" | |||
| CART_USD = ASSET_PATH + "Props/Lightwheel/Assets/Cart003/Cart003.usd" | |||
There was a problem hiding this comment.
S3 path case-sensitivity may break asset loading
AWS S3 object keys are case-sensitive. Renaming the URL path segment from Props/LightWheel/ to Props/Lightwheel/ will return HTTP 403/404 for every asset unless the objects in the omniverse-content-production S3 bucket have already been moved or re-keyed to match the new casing. Please confirm the S3-side paths have been updated before merging, or these asset URLs will silently fail at runtime.
Fixes #ISSUE_NUMBER
Rename LightWheel to Lightwheel