Stop emitting invalid omni-github log paths

[chiahaol-nv]

Description

omni-github interprets log_paths as files relative to the uploaded
test-result artifact. Isaac Lab was putting external GitHub artifact URLs in
that field, so ingestion emitted log_path_not_found warnings for every
converted test row.

This change omits log_paths from converted rows. The existing JUnit and
comparison-image artifact uploads remain unchanged.

To view an example of warning logs:

1. Visit this workflow upload result and click "Load"
2. Click any "View report" link with status as Processed_with_warnings in the "Processing Evidence" table.
3. You'll see many log_path_not_found warnings as the screenshot below shows

Type of change

• Bug fix (non-breaking)

Validation

• pytest .github/actions/upload-omni-github-test-results/test_junit_to_omni_github_results.py
  — 4 passed
• Ruff and Ruff format passed for the modified files.
• The all-files pre-commit run passed every available hook. The Git LFS pointer
  hook could not run because git-lfs is not installed on the development
  host.

Checklist

• The change is focused and includes regression coverage.
• No package under source/ was changed, so no changelog fragment is
  required.
• No documentation or dependency changes are required.

[isaaclab-review-bot]

Isaac Lab Review Bot

Summary

This change stops emitting log_paths in converted omni-github test rows, since omni-github interprets that field as artifact-relative file paths rather than external URLs. The converter edit is a single-line deletion, and the corresponding test was renamed and updated to assert the key is absent. The fix matches the described ingestion warning and is low risk.

Architecture impact

Confined to the CI helper under .github/actions/upload-omni-github-test-results/. No runtime or public API surface is affected, and JUnit/comparison-image artifact uploads remain unchanged.

Test coverage

The updated regression test passes non-empty artifact URLs and asserts log_paths is absent from the emitted row, which would fail against the previous implementation (the key was always present). The dict-equality assertion in the crash/timeout test also pins the exact row schema. Coverage is adequate; the only gap is that nothing exercises the now-unused URL plumbing.

Implementation verdict

Minor fixes needed. Posted 1 actionable finding inline.

Automated comment-only review; human maintainers own approval decisions.

[isaaclab-review-bot]

🔵 Suggestion — Artifact URL inputs are now dead plumbing and the assertion is narrow

After dropping log_paths from the row, convert_junit still builds the log_paths list from junit_log_url/comparison_images_url, _convert_testcase still accepts an unused log_paths parameter, and both --junit-log-url and --comparison-images-url remain required=True on the CLI while feeding nothing. A future caller will reasonably assume those flags are wired up. Consider removing the unused parameter and list construction in junit_to_omni_github_results.py (making the CLI flags optional or dropping them alongside the action YAML that passes them). Independently, this assertion only pins the key name for the first row — reintroducing the URLs under a different key, or in additional rows, would still pass. Broadening it makes the test sensitive to the actual invariant.

Suggested change

	assert "log_paths" not in rows[0]
	assert all("log_paths" not in row for row in rows)
	result_text = (output_dir / _RESULT_PATH).read_text(encoding="utf-8")
	assert junit_log_url not in result_text
	assert comparison_images_url not in result_text

[greptile-apps]

Greptile Summary

Removes invalid external artifact URLs from converted omni-github test rows.

• Omits the optional log_paths field during JUnit conversion.
• Updates regression tests to verify that external artifact URLs are not emitted as per-test log paths.

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

The result schema permits omission of log_paths, and the converter only populated it with external artifact URLs that do not satisfy the field’s intended artifact-relative-path semantics.

Important Files Changed

Filename	Overview
.github/actions/upload-omni-github-test-results/junit_to_omni_github_results.py	Removes the optional log_paths property whose generated values were external artifact URLs rather than artifact-relative paths.
.github/actions/upload-omni-github-test-results/test_junit_to_omni_github_results.py	Updates expected rows and adds focused regression coverage confirming that invalid external URLs are omitted.

_{Reviews (1): Last reviewed commit: "Stop emitting invalid omni-github log pa..." | Re-trigger Greptile}

[mataylor-nvidia]

I would remove log path collection entirely if omnighithub is only for observability and does not persist the logs