fix(io): use multiprocessing for repack_rasters#731
Open
scottstanie wants to merge 1 commit into
Open
Conversation
rasterio is not thread-safe; running repack across a thread pool can corrupt/deadlock on some GDAL builds. Switch repack_rasters to a process pool. Use ProcessPoolExecutor directly with an explicit forkserver mp_context rather than tqdm's process_map, which does not forward mp_context to the underlying executor. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
repack_rasterscurrently repacks files across a thread pool, but rasterio /GDAL is not thread-safe for concurrent dataset access; on some GDAL builds this
can corrupt output or deadlock.
Change
repack_rastersfrom a thread pool to a process pool.ProcessPoolExecutordirectly with an explicitforkservermp_context,rather than
tqdm.contrib.concurrent.process_map(which does not forwardmp_contextto the underlying executor, so the intended start method wassilently ignored).
Behavior is otherwise unchanged (same inputs/outputs, same progress bar).
🤖 Generated with Claude Code