Removed the double deduction of the prepayment from var remainingLoan… - #12
Open
ankitsikka1992 wants to merge 1 commit into
Open
Removed the double deduction of the prepayment from var remainingLoan…#12ankitsikka1992 wants to merge 1 commit into
ankitsikka1992 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix part payment calculation bug in loan amortization
Summary
This PR fixes a critical bug in the loan calculation logic where part payments were being deducted twice from the remaining loan balance, resulting in incorrect amortization schedules and misleading payment breakdowns.
Problem
When users entered part payments (prepayments), the application was:
This caused the part payment to be subtracted twice, leading to incorrect loan balances and confusing users about their actual payment breakdown.
Solution
Modified the calculation logic in
js/calc.jsto:Changes
calculateLoanSchedule()functionTesting
Tested the fix with various scenarios:
Type of Change
This fix resolves calculation accuracy issues without changing the user interface or breaking existing functionality.