Fixed lubimyczytać.pl metadata provider - #3659
Merged
Merged
Conversation
|
Confirm this is working for me too, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
this PR fixes the lubimyczytac.pl metadata provider.
Issue
The website changed its interface recently, which broke the parsing completely. Also some parser features were missing for a long time.
Fix
The fix was simple: I've updated the XPaths to account for the current HTML structure of lubimyczytac.pl. Also, I've added a one-line function to parse the published date parameter, which displayed a little differently by lubimyczytac.pl then it used to be.
Comments
I've tested my changes against a few books, looks good to me.
I'm creating this PR on the
masterbranch, notDevelop, because I think these are simple changes, no new features added.Please let me know if this is ok.