Skip encoding params for explain query#821
Merged
albertyw merged 1 commit intojazzband:masterfrom Sep 9, 2025
Merged
Conversation
5d04148 to
24eac06
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #821 +/- ##
==========================================
+ Coverage 87.04% 87.15% +0.10%
==========================================
Files 53 53
Lines 2169 2164 -5
==========================================
- Hits 1888 1886 -2
+ Misses 281 278 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
24eac06 to
a11d58c
Compare
a11d58c to
57353c1
Compare
Comment on lines
63
to
64
| result = _unpack_explanation(cur.fetchall()) | ||
| return '\n'.join(result) |
Contributor
Member
Author
There was a problem hiding this comment.
Looking at #819 , the error people are getting seem to be an error from the postgresql database itself. That would only happen in the cur.execute() so the exception happens before these two lines are even reached.
Member
Author
|
Merging this in given the confirmation from #819 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #819
Reverts #798 , #807
@glennmatthews the
_explain_queryswitched from using the rawparamsto string params as of #798 . Since theparamshere are only used for executing the query and are not later saved to a DB like inexecute_sql, I'm not sure whyparamsneeded to beforce_stred? As in #819, some database fields are binary and either cannot be decoded (fixed in the try/catch) or should not be decoded even if they can be decoded.