Bug fix: Submenus with spaces are not matched against url. - #150
Open
ajarzyn wants to merge 1 commit into
Open
Conversation
Author
|
@kytta hey could you please check this PR. |
kytta
self-requested a review
May 20, 2025 16:16
Member
|
Code looks good; will test later today when I get home |
kytta
requested changes
Jun 9, 2025
kytta
left a comment
kytta
left a comment
Member
There was a problem hiding this comment.
The code works, but only for inexact URL matches (the default). See my comments for more info
| if re.match(f"{self.url}$", request.path): | ||
| matched = True | ||
| elif re.match("%s" % self.url, request.path): | ||
| elif re.match("%s" % unquote_plus(self.url), request.path): |
Member
There was a problem hiding this comment.
question: Why unquote_plus?
The only reason to use it instead of unquote is to parse HTML form values, but since we only work with URL path segments, I propose we just use unquote
suggestion:
Suggested change
| elif re.match("%s" % unquote_plus(self.url), request.path): | |
| elif re.match("%s" % unquote(self.url), request.path): |
Comment on lines
259
to
260
| if self.exact_url: | ||
| if re.match(f"{self.url}$", request.path): |
Member
There was a problem hiding this comment.
issue: Your fix won't work for exact_url
When you create a MenuItem with exact_url=True, the old behaviour will apply.
suggestion: Also add unquoting to this branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #149