feat(analytics): first-party /_a footer in generated docs (ADR-0006 Phase 2c follow-up)#44
Merged
Merged
Conversation
…06 Phase 2c) #43 updated jsdoc.json (the config), but api-docs deploys by rsyncing the COMMITTED docs/ build artifact — it does not build on deploy — so the live site still served the cross-origin tracker. This regenerates the footer in the committed HTML to match the updated jsdoc.json. Uniform, surgical swap across all 545 generated pages: - src="https://analytics.jellyrock.app/script.js" + src="/_a/script.js" … data-host-url="https://api.jellyrock.app/_a" Identical to what `npm run build` now emits (jsdoc.json is already first-party on main), so the next code-update regeneration produces no footer diff. Events POST to /_a/api/send → Caddy strips to umami /api/send. analytics.jellyrock.app stays live as rollback (Bridge).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2c follow-up. #43 updated
jsdoc.json, but api-docs deploys byrsync-ing the committeddocs/artifact (no build on deploy), so the liveapi.jellyrock.appstill served the cross-origin tracker. This regenerates the footer in the committed HTML.src="https://analytics.jellyrock.app/script.js"→src="/_a/script.js"+data-host-url="https://api.jellyrock.app/_a".npm run buildnow emits (jsdoc.jsonis first-party on main), so the nextcode-updateregeneration yields no footer diff.Verification
grep: 0analytics.jellyrock.apprefs, 545/_a/script.jsrefs indocs/.analytics-health.sh --only api-docs→ first-party/ok (this is the change that actually flips the live site).