Add blank line rule in port_map#1450
Add blank line rule in port_map#1450lgu-appear wants to merge 10 commits intojeremiah-c-leary:masterfrom
Conversation
|
The test |
benthie
left a comment
There was a problem hiding this comment.
Looks good as far as I can tell. I think the commits have to be squashed before this can be merged.
Could you also implement this rule as generic_map_201?
|
Good point, I can add the generic thing as you mention! |
Signed-off-by: Rui Chen <rui@chenrui.dev>
|
Afternoon @lgu-appear and @benthie , I reviewed the two rules and made a slight change to take comments into account. If there are no comments, then the rule behaves the same as your original rule. If there are comments then the rule stops removing blank lines up to the comment. I am ready to merge this to master, but wanted to your feedback on my changes. Thanks for the PR. --Jeremy |
|
Hey! Thanks for reviewing. Can there be the possibility to include or not the blank line above the comments? In my case, I do not want any blank line, even above comments. Loan |
Description
Add a rule for detecting blank lines in the port map of an instantiation of a module.
Screenshots
See
tests\port_map\rule_201_test_input.vhdandtests\port_map\rule_201_test_input.fixed.vhd.