Issue#1503: Added new rules for structure and alignment of multiline signal initialisations#1505
Issue#1503: Added new rules for structure and alignment of multiline signal initialisations#1505JHertz5 wants to merge 24 commits intojeremiah-c-leary:masterfrom
Conversation
… signal declaration default value.
|
Marking as a draft because the feature requester still wants more features. |
…t a different line than preceding tokens.
…ator is not a different line than preceding tokens.
…tor is not a different line than preceding tokens.
|
Evening @JHertz5 , I just wanted to let you know that I appreciate all your work on this project with helping to address issues others are having and all the PRs you have submitted. With the high quality of the PRs you submit, I can't really see why most of them need to go through me. If I can figure out how to give you permissions to commit to master would you be interested in having that kind of access on this project? Regards, --Jeremy |
Thanks very much! VSG has been extremely useful to me so I'm glad to be able to "give back" somewhat.
I would be honoured! I'd definitely be open to that if it's possible - it also frees up your time to be spent on more valuable areas of the project, I'm aware that a backlog of PRs to review is probably not how you'd like to spend the little time that you have to work on the project 😅 From a quick google, there is not a lot of granularity in the permissions settings for repositories owned by a personal account. You can add someone as a collaborator, which, by the looks of it, gives them a lot of permissions, e.g. merging PRs, managing releases, etc. which you may not be comfortable with. It looks like you can only give more granular permissions if your repo is within an organisation. I don't know if a repo can be easily transferred to being within an organisation, it sounds like a hassle. If you're not comfortable with adding someone as a collaborator, I absolutely understand - I'm also totally happy to have my PRs wait until you've had a chance to look at them. |
|
Evening @JHertz5 ,
I just added you as a collaborator. At some point we will have to go through how I manage issues using the project view and performing a release.
I can tell from the PRs you submit that you have the best interests of the project in mind. From the minor grammar updates in error messages and fixing issues in the documentation, to keeping within the design patterns of the code structure, and how you interact with the other users when solving issues. That is why I feel I can give you ability to merge PRs and make releases. Again, thanks for all your effort. Regards, --Jeremy |
|
Thanks so much! I've accepted the invtiation and look forward to making many more contributions!
That sounds like a good plan. Perhaps we move the conversation to a discussion when you're ready. Thanks again, |
…ine_alignment_between_tokens in signal_400! Greatly simplified my solution.
|
Marking as ready for review again as I've implemented the other features that the feature requester has requested. Just waiting for their validation. |
Resolves #1503.
Note
The behaviour of
signal_400has been modified to skip arrays as part of these changes. FYI @jeremiah-c-leary.