Skip to content

Add tespy and heatpumps model export - #54

Merged
jfreissmann merged 2 commits into
jfreissmann:feat/save-load-hpsfrom
HaSchneider:dev
Jul 9, 2026
Merged

Add tespy and heatpumps model export#54
jfreissmann merged 2 commits into
jfreissmann:feat/save-load-hpsfrom
HaSchneider:dev

Conversation

@HaSchneider

Copy link
Copy Markdown

Add buttons in streamlit dashboard to export the model as disscussed in #53 as tespy json file or heatpumps json configuration file as implemented in PR #50.

Curretly #50 allows only an export when simulation fails, thats why I added the button in the regular result field. This could also be moved to #50 if preferred.

@HaSchneider

Copy link
Copy Markdown
Author

There is currently the issue that the imported models in tespy are not properly configured. There are too many parameters provided. Any ideas why?
The heatpumps import works and solves fine (if executed in https://github.com/fwitte/heatpumps.git).

@fwitte

fwitte commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

There is currently the issue that the imported models in tespy are not properly configured. There are too many parameters provided. Any ideas why? The heatpumps import works and solves fine (if executed in https://github.com/fwitte/heatpumps.git).

I believe heatpumps does some kind of prerpocessing (i.e. setting up a new class instance of that heat pump and presetting the default boundary conditions). Depending on when you export the Network of the heatpumps class it might have wrong parameter specifications (or it is a bug).

In any case, I like the idea and would say just merge the them? So first merge #50, then merge the changes to here, figure out what is the problem with the tespy Network deserialization and execution and then merge this one.

@fwitte

fwitte commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Found it, was a bug in tespy deserialization. I will fix that and make a release.

@jfreissmann
jfreissmann changed the base branch from dev to feat/save-load-hps July 9, 2026 12:07
@jfreissmann
jfreissmann merged commit 6d44fcd into jfreissmann:feat/save-load-hps Jul 9, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants