Skip to content

feat: Add reply to message - #103

Open
Eelyousha wants to merge 2 commits into
julez-dev:mainfrom
Eelyousha:feat/reply-support
Open

feat: Add reply to message#103
Eelyousha wants to merge 2 commits into
julez-dev:mainfrom
Eelyousha:feat/reply-support

Conversation

@Eelyousha

Copy link
Copy Markdown
Contributor

Added default "reply to message", for now, in app it looks like mention (same as @user), but in Twitch chat looks totally like "true" reply. For feat issue #100

Signed-off-by: Ilya <qubelord777@gmail.com>
Signed-off-by: Ilya <qubelord777@gmail.com>

@julez-dev julez-dev left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, feature, have some findings.

Also I think a future UX improvement for this feature could be a UI indicator of the current message user is replying to, which will also make it clear what state the input is in. Similar to how twitch displays it.

Its up to you if you want to create a new issue for that or implement that feature inside of this.

Thanks!

userID := t.account.ID

replyTo := t.replyToMessageID
t.replyToMessageID = ""

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The replyToMessageID is not cleared when command branch is reached, resulting in unexpected reply message after using command.

To reproduce:

alt+r on message -> use command (f.e /emotes) -> go into insert mode again (no reply) -> type message -> message is still a reply to the original message alt+r was pressed on

} else {
t.state = insertMode
}
log.Info().Str("messageID", msg.ID).Str("messageText", msg.Message).Msg("Message info")

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove please

Comment on lines +1491 to +1496
// Get message and IDs from PrivateMessage
//
// func (t *broadcastTab) handleResponseToMessage() tea.Cmd {
// msg, ok := entry.Event.message.(*twitchirc.PrivateMessage)

// }

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants