Render CURRENT_DATE and CURRENT_TIME as bare keywords - #3523
Open
arpitjain099 wants to merge 1 commit into
Open
Conversation
CurDate and CurTime emitted CURRENT_DATE() and CURRENT_TIME() with empty parentheses, which is invalid in PostgreSQL and standard SQL where these are keywords rather than function calls. CurTimestamp already overrides get_function_sql to drop the parens; mirror that on CurDate and CurTime. Updates the two existing tests that asserted the parenthesized form. Fixes kayak#809 Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #809.
CurDate()andCurTime()were rendering asCURRENT_DATE()andCURRENT_TIME(), but in PostgreSQL and standard SQL those are keywords, not function calls, so the trailing parentheses make the query invalid.CurTimestampalready handles this by overriding get_function_sql to drop the parens, so I did the same for the other two and updated the two existing tests that were asserting the old parenthesized output. I ran the full test suite locally and everything passes. Thanks for taking a look.