Skip to content

fix: unit tests#6298

Open
Walkablenormal wants to merge 4 commits intokeephq:mainfrom
Walkablenormal:fix_unit_tests
Open

fix: unit tests#6298
Walkablenormal wants to merge 4 commits intokeephq:mainfrom
Walkablenormal:fix_unit_tests

Conversation

@Walkablenormal
Copy link
Copy Markdown
Contributor

@Walkablenormal Walkablenormal commented Apr 25, 2026

Closes #6297

📑 Description

Hi,

In my PR #6296 I've noticed the unit-tests failing. This PR contain the fixes for the failing tests.

The first issue was importing and mapping the severity-field in one of the tests.
The second issue was calling a function that has been replaced by another function.

✅ Checks

  • My pull request adheres to the code style of this project
  • [N] My code requires changes to the documentation
  • [N] I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

Signed-off-by: Walkablenormal <rubenvankomen@gmail.com>
Signed-off-by: Walkablenormal <rubenvankomen@gmail.com>
@Walkablenormal Walkablenormal changed the title Fix unit tests fix: unit tests Apr 25, 2026
Signed-off-by: Walkablenormal <rubenvankomen@gmail.com>
Signed-off-by: Walkablenormal <rubenvankomen@gmail.com>
@Walkablenormal Walkablenormal marked this pull request as ready for review April 25, 2026 20:44
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 25, 2026
@Walkablenormal
Copy link
Copy Markdown
Contributor Author

Hi,

I think this is ready for review too. E2E test seems to be kinda flakey.

@shahargl can you review and PR this please?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Unit tests failing (see tests from PR #6296)

1 participant