feat(web): extend search-graph test-helper funcs to handle specialized spur types 🚂#15721
Open
jahorton wants to merge 3 commits into
Open
feat(web): extend search-graph test-helper funcs to handle specialized spur types 🚂#15721jahorton wants to merge 3 commits into
jahorton wants to merge 3 commits into
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
Bot
changed the title
jahorton
force-pushed
the
feat/web/deletion-spurs
branch
from
2343ac4 to
044a634
Compare
jahorton
force-pushed
the
feat/web/extend-graph-test-helpers
branch
from
80c970d to
dabce3b
Compare
This was referenced Mar 11, 2026
jahorton
force-pushed
the
feat/web/deletion-spurs
branch
from
d2e5df4 to
09db6a4
Compare
jahorton
force-pushed
the
feat/web/extend-graph-test-helpers
branch
from
0bed20a to
9165e8f
Compare
jahorton
force-pushed
the
feat/web/deletion-spurs
branch
from
09db6a4 to
f27763f
Compare
jahorton
force-pushed
the
feat/web/extend-graph-test-helpers
branch
from
9165e8f to
9285721
Compare
jahorton
force-pushed
the
feat/web/deletion-spurs
branch
from
f27763f to
04183cc
Compare
jahorton
force-pushed
the
feat/web/extend-graph-test-helpers
branch
from
9285721 to
cc8d314
Compare
…d spur types Build-bot: skip build:web Test-bot: skip
jahorton
force-pushed
the
feat/web/deletion-spurs
branch
from
04183cc to
4816729
Compare
jahorton
force-pushed
the
feat/web/extend-graph-test-helpers
branch
from
cc8d314 to
feba7cd
Compare
ermshiperete
requested changes
May 13, 2026
Contributor
ermshiperete
left a comment
ermshiperete
left a comment
There was a problem hiding this comment.
Requesting changes because I think the assertion on one of the tests is wrong. Otherwise LGTM.
|
|
||
| const k2c3Constituents = constituentPaths(k2c3); | ||
|
|
||
| const shouldNotOccur = k2c3Constituents.find((seq) => { |
Contributor
There was a problem hiding this comment.
From devin.ai. Might be better to use k2c3Constituents.some(.... (Same in the next test)
Co-authored-by: Eberhard Beilharz <ermshiperete@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build-bot: skip build:web
Test-bot: skip