Open
Conversation
|
@lionello What is the issue with the current implementation of OID in DName? |
Contributor
Author
|
@Ruffio The old implementation would throw an exception when an 'unknown' OID was encountered in the DName, 'unknown' meaning an OID that wasn't explicitly hardcoded in jsrsasign. With this patch, unknown OIDs are not converted to strings and simply output as numbers. |
Contributor
Author
|
It's impossible to add "all" OIDs, since new ones can be created at any time. The library should provide a way to obtain unknown OIDs (these are not invalid, so an exception seems misplaced.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch allows one to add any OID name-value pair in a DName structure.