mcp: set HasPrompts to false since no prompts are registered#3690
mcp: set HasPrompts to false since no prompts are registered#3690Elvand-Lie wants to merge 1 commit into
Conversation
The MCP server declares HasPrompts: true in its capabilities but no prompts are registered. Per the MCP specification, clients may call prompts/list when this capability is advertised and expect results. Set HasPrompts to false to accurately reflect the server capabilities. Fixes knative#3689 Signed-off-by: elvandlie@gmail.com <elvandlie@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Elvand-Lie The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @Elvand-Lie. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
PTAL @lkingland |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3690 +/- ##
==========================================
- Coverage 56.90% 56.90% -0.01%
==========================================
Files 181 181
Lines 20933 20933
==========================================
- Hits 11912 11911 -1
- Misses 7811 7813 +2
+ Partials 1210 1209 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The MCP server declares
HasPrompts: truein its capabilities but no prompts are registered. Per the MCP specification, clients may callprompts/listwhen this capability is advertised and expect results.Set
HasPromptstofalseto accurately reflect the server capabilities.Changes
HasPromptstofalsein MCP server options since no prompts are registeredFixes #3689
Release Note