mcp: add missing help resource for delete command#3724
Conversation
|
|
|
Welcome @cubaseuser123! It looks like this is your first PR to knative/func 🎉 |
|
Hi @cubaseuser123. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
knative-prow
Bot
added
size/XS
|
/ok-to-test |
knative-prow
Bot
added
ok-to-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cubaseuser123, gauron99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
Bot
added
the
approved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3724 +/- ##
==========================================
+ Coverage 56.95% 56.97% +0.02%
==========================================
Files 181 181
Lines 21116 21117 +1
==========================================
+ Hits 12026 12031 +5
+ Misses 7866 7862 -4
Partials 1224 1224
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
Changes
Hi! I'm new to the repo and was just exploring the codebase. While mapping out the tool-to-resource architecture in
pkg/mcpto understand how things work, I noticed a small gap.Every registered tool in
mcp.gohas a correspondingfunc://help/<command>resource for flag discovery (build, deploy, list, etc.). But thedeletetool was missing its help resource. It looks like it slipped through the cracks during a previous MCP refactor.This PR adds it:
func://help/deleteusing the existingnewHelpResourcefactory pattern.TestResource_Helpsuite inresources_test.go.(Side note: the
deletetool has a destructive annotation and a readonly guard, so making its parameters discoverable via--help, I think it feels important for agent interactions.)Ran the
mcppackage tests locally and everything passes fine./kind cleanup
There is no open issue for this, just something I found while exploring the code. Let me know if there are any changes to make, thanks.