mcp: add missing test coverage for Remove help resources#3747
Conversation
The Remove help resources for config volumes, labels, and envs were registered correctly in mcp.go but had no test coverage, making it impossible to catch regressions. Adds three test cases to TestResource_Help verifying the correct command paths for config volumes/labels/envs remove help resources. Fixes knative#3711 Signed-off-by: Thonmay <mdthoriqulislam384@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: thonmay The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
knative-prow
Bot
added
the
size/S
|
Hi @thonmay. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
knative-prow
Bot
added
the
needs-ok-to-test
|
Closing in favor of #3712 by @xenonnn4w which fixes the underlying bug. Thanks. |
1 participant
Changes
The Remove help resources for
config volumes,config labels, andconfig envswere registered correctly inmcp.gobut had no test coverage. Regressions in the command paths could go undetected.Adds three test cases to
TestResource_Helpverifying the correct URIs and command args:func://help/config/volumes/removemaps toconfig volumes remove --helpfunc://help/config/labels/removemaps toconfig labels remove --helpfunc://help/config/envs/removemaps toconfig envs remove --help/kind bug
Fixes #3711