Updated API signature for some libraries and fixed them in dependencies - #5
Open
aibolik wants to merge 2 commits into
Open
Updated API signature for some libraries and fixed them in dependencies#5aibolik wants to merge 2 commits into
aibolik wants to merge 2 commits into
Conversation
|
The changes in this PR plus the one line below got it working for me! Thanks! - var events = response.items;
+ var events = response.data.items;I also added option + click on a calendar event to open the event's Google Hangout link since most of my meetings are Google Hangouts. Meetings without a Hangout link are greyed out when option is held down. var str = `${evnts[d][s].time} - ${evnts[d][s].summary}`;
if (process.env.BitBar) {
- str += ` | href=${evnts[d][s].htmlLink}`;
+ str += ' |';
if (cfg.eventColor) { str += ` color=${cfg.eventColor}`; }
if (cfg.eventFont) { str += ` font=${cfg.eventFont}`; }
if (cfg.eventLength) { str += ` length=${cfg.eventLength}`; }
if (cfg.eventSize) { str += ` size=${cfg.eventSize}`; }
+
+ altStr = str;
+
+ str += ` href=${evnts[d][s].htmlLink}`;
+ altStr += evnts[d][s].hangoutLink ? ` href=${evnts[d][s].hangoutLink}` : '';
+ altStr += ' alternate=true';
}
console.log(str);
+ console.log(altStr);
e++;
}
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, thanks for this awesome BitBar plugin!
I really liked it, but at first it did not work. Since it was in NodeJS I decided to fix problems. I fixed it on my local copy and it now works fine.
Please review and accept PR and publish latest version to NPM.
Changes:
googleapis(google-auth-library now is not needed) and forhapi(apparently, it moved to@hapi/hapiand API methods changed a bit)npmDeps, so that they will use exact version. That way, you don't need to care much about API changes, since the implementation is tied to specific version.Best wishes