Fix/kody language flash on refresh - #1584
Conversation
|
This PR was not deployed automatically as @Nalu-devs does not have access to the Railway project. In order to get automatic PR deploys, please add @Nalu-devs to your workspace on Railway. |
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
Preview Environment
|
![kody-ai[bot]](https://avatars.githubusercontent.com/in/413034?s=60&v=4){kind=small}
…ed bridge Replace per-parameter InitialLanguageConfigProvider with a generic InitialParametersProvider keyed by ParametersConfigKey. This follows the existing shell pattern (SSR seed + live query + invalidation): - SSR-fetch LANGUAGE_CONFIG in settings/layout.tsx and pass via initialParameters map to InitialParametersProvider - In [repositoryId]/layout.tsx, combine liveQuery?.configValue ?? initialParameter?.configValue ?? ENGLISH (same idiom as shell) - Add LANGUAGE_CONFIG invalidation in use-code-review-settings-mutation so language updates propagate after in-place save - Revert hook signature change in useOptionalParameterQuery (keep it backward-compatible, no options.initialData added) The generic bridge scales: any future parameter with flash-on-refresh only needs a new key in the map, not a bespoke provider.
04b6fdf to
b105cf1
Compare
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
- Carry initialTeamId inside InitialParametersBridge so consumers can guard the SSR seed against stale-team paints (shell-equivalent pattern of effectiveTeamId === initialTeamId). - Remove two TEMP DEBUG console.log blocks left over from development.
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
2 participants
#1520