You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While the change set effectively removes lodash.merge as a dependency, the MR lacks accompanying documentation or a description to clarify the rationale behind this change.
It would be beneficial to understand the purpose of this change. Is the goal to reduce dependencies, improve performance, or something else?
Also, it's worth noting that lodash.merge and Object.assign are not like-for-like replacements. lodash.merge performs a deep merge, while Object.assign performs a shallow merge. However, upon review of the changed code snippet:
it seems like a deep merge might not be necessary in this context. Therefore, using Object.assign appears to be appropriate for this specific use case.
Is it worth updating the MR description to include the rationale behind this change for the sake of clarity?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.