Skip to content

feat: add Node Readiness Controller (nrc) minikube addon#22924

Open
arnab-logs wants to merge 2 commits intokubernetes:masterfrom
arnab-logs:feat/add-nrc-addon
Open

feat: add Node Readiness Controller (nrc) minikube addon#22924
arnab-logs wants to merge 2 commits intokubernetes:masterfrom
arnab-logs:feat/add-nrc-addon

Conversation

@arnab-logs
Copy link
Copy Markdown
Member

Fixes kubernetes-sigs/node-readiness-controller#188
cc: @ajaysundark

What this PR does

This PR adds a new Minikube addon for the Node Readiness Controller (NRC).

This addon is part of enabling easier adoption and testing of NRC and enables a lifecycle-managed way to deploy NRC in Minikube using: minikube start --addons=nrc

Implementation details

  • Adds new addon: nrc
  • Includes:
    • NRC controller static Pod manifest
    • CRD definition for NodeReadinessRule
  • Runs in kube-system namespace
  • Uses control-plane co-located deployment model
  • Resources are labeled with: kubernetes.io/minikube-addons: nrc

How to test

Build and start

make
./out/minikube start --addons=nrc

Verify installation

kubectl get pods -n kube-system -l component=node-readiness-controller
image
kubectl get crd nodereadinessrules.readiness.node.x-k8s.io
image

Verify scheduling (control-plane)

kubectl get pods -n kube-system -l component=node-readiness-controller -o wide
image

Check logs

kubectl logs -n kube-system -l component=node-readiness-controller
image

Disable and cleanup

./out/minikube addons disable nrc --alsologtostderr
image

Verify cleanup:

kubectl get pods -n kube-system -l component=node-readiness-controller
kubectl get crd nodereadinessrules.readiness.node.x-k8s.io
image

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arnab-logs
Once this PR has been reviewed and has the lgtm label, please assign comradeprogrammer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 1, 2026
@k8s-ci-robot k8s-ci-robot requested review from medyagh and prezha May 1, 2026 20:50
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 1, 2026
@minikube-bot
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@ajaysundark
Copy link
Copy Markdown

/retest

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 2, 2026

@arnab-logs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-minikube-docker-crio-linux-x86 19330c5 link false /test pull-minikube-docker-crio-linux-x86
pull-minikube-docker-containerd-linux-arm 19330c5 link false /test pull-minikube-docker-containerd-linux-arm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: minikube addon for NRC

4 participants