Skip to content

ISO: use binaries for docker buildx instead of build from source#22942

Merged
medyagh merged 4 commits intokubernetes:masterfrom
medyagh:fix-docker-buildx-buildroot
May 6, 2026
Merged

ISO: use binaries for docker buildx instead of build from source#22942
medyagh merged 4 commits intokubernetes:masterfrom
medyagh:fix-docker-buildx-buildroot

Conversation

@medyagh
Copy link
Copy Markdown
Member

@medyagh medyagh commented May 6, 2026

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from nirs and prezha May 6, 2026 16:25
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 6, 2026
@medyagh medyagh changed the title Fix docker buildx buildroot ISO: use binaries for docker buildx instead of build from source May 6, 2026
@medyagh
Copy link
Copy Markdown
Member Author

medyagh commented May 6, 2026

/ok-to-build-iso

@minikube-bot
Copy link
Copy Markdown
Collaborator

Hi @medyagh, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 6, 2026
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 6, 2026
@medyagh
Copy link
Copy Markdown
Member Author

medyagh commented May 6, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 6, 2026
@minikube-pr-bot
Copy link
Copy Markdown

kvm2 driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 22942 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 38.9s    │ 39.7s                  │
│ enable ingress │ 19.1s    │ 19.0s                  │
└────────────────┴──────────┴────────────────────────┘
Details

Times for minikube start: 41.0s 37.3s 37.8s 37.8s 40.8s
Times for minikube (PR 22942) start: 38.5s 41.0s 37.6s 40.1s 41.1s

Times for minikube ingress: 18.8s 18.8s 19.3s 19.3s 19.3s
Times for minikube (PR 22942) ingress: 18.8s 19.3s 18.8s 19.3s 18.8s

docker driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 22942 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 19.5s    │ 19.5s                  │
│ enable ingress │ 12.1s    │ 12.5s                  │
└────────────────┴──────────┴────────────────────────┘
Details

Times for minikube start: 21.6s 18.6s 18.8s 19.1s 19.4s
Times for minikube (PR 22942) start: 20.8s 18.3s 18.3s 21.6s 18.4s

Times for minikube ingress: 12.6s 12.6s 10.6s 12.7s 12.1s
Times for minikube (PR 22942) ingress: 12.7s 12.6s 12.6s 12.1s 12.6s

docker driver with containerd runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 22942 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 18.4s    │ 18.4s                  │
│ enable ingress │ 24.5s    │ 24.5s                  │
└────────────────┴──────────┴────────────────────────┘
Details

Times for minikube start: 18.7s 19.8s 19.7s 16.9s 16.8s
Times for minikube (PR 22942) start: 17.1s 16.7s 19.6s 19.0s 19.4s

Times for minikube ingress: 25.1s 25.1s 24.6s 23.1s 24.6s
Times for minikube (PR 22942) ingress: 25.1s 22.7s 24.6s 25.1s 25.1s

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 6, 2026

@medyagh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-minikube-none-docker-linux-x86 06c3006 link true /test pull-minikube-none-docker-linux-x86
pull-minikube-docker-docker-linux-x86 06c3006 link true /test pull-minikube-docker-docker-linux-x86
pull-minikube-kvm-crio-linux-x86 06c3006 link false /test pull-minikube-kvm-crio-linux-x86

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@medyagh medyagh merged commit 70868f9 into kubernetes:master May 6, 2026
39 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants