chore(lint): fix golangci-lint 2.13.1 findings - #18209
Merged
bartsmykla merged 1 commit intoAug 25, 2026
Merged
Conversation
The 2.13.1 bump enabled modernize's embedlit check, which flags the redundant embedded ObjectMeta type in struct literals. Master's check job is red and every open PR inherits the failure. Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
bartsmykla
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The golangci-lint bump to 2.13.1 (#18189) enabled modernize's
embedlitcheck, which flags the redundant embeddedObjectMetatype in struct literals. Seven of those live inhttp_route_controller_test.go, so thecheckjob is red on master and every open PR inherits the failure.Implementation information
Dropped the redundant
ObjectMeta: kube_meta.ObjectMeta{...}wrapper in the seven flagged literals;ObjectMetais embedded in bothMeshServiceand the core Kubernetes types, so the fields are set directly. Mechanical change, no behavior difference. Thekube_metaimport stays, it is still used elsewhere in the file.Verified with
golangci-lint run --fix=false(the flag CI passes) on the package: 0 issues. Build, vet, and the package tests pass.Supporting documentation
Follows the same pattern as #18194 for the previous lint bump.