Skip to content

fix: Use node package.json as template for pkg/package.json - #807

Open
kylebarron wants to merge 1 commit into
mainfrom
kyle/use-node-package-json-as-base
Open

fix: Use node package.json as template for pkg/package.json#807
kylebarron wants to merge 1 commit into
mainfrom
kyle/use-node-package-json-as-base

Conversation

@kylebarron

Copy link
Copy Markdown
Owner

No description provided.

@github-actions

github-actions Bot commented Oct 6, 2025

Copy link
Copy Markdown
Asset Size Compressed Size
report_pkg/async_full/parquet_wasm_bg.wasm 6.7MB 1.3MB
report_pkg/slim/parquet_wasm_bg.wasm 4.9MB 678KB
report_pkg/sync/parquet_wasm_bg.wasm 6.2MB 1.2MB

@amoeba

amoeba commented Apr 14, 2026

Copy link
Copy Markdown

Hey @kylebarron, I ran into this and I can confirm the fix in this PR would work for me. I have a local ESM project and was able to get import { readParquet } from "parquet-wasm/node"; working once I added this post-install script to delete the type field from the package.json:

-- >8 -- 
  "scripts": {
    "postinstall": "node -e \"const fs=require('fs'),p=JSON.parse(fs.readFileSync('./node_modules/parquet-wasm/package.json'));delete p.type;fs.writeFileSync('./node_modules/parquet-wasm/package.json',JSON.stringify(p,null,2));\"",
-- >8 -- 

@kylebarron

Copy link
Copy Markdown
Owner Author

Thanks for the acknowledgement. I think we might need a wholesale re-architecting of how the builds are made, along with good dev docs about how it works

@amoeba

amoeba commented Apr 20, 2026

Copy link
Copy Markdown

Do you want to file an issue and put your thoughts down? And if you don't think you'd have time to do it, I can try.

@kylebarron

Copy link
Copy Markdown
Owner Author

I don't have the time/energy to put into this project right now 😕

Happy to follow your suggestions to unblock some of these recurrent issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants