fix: Use node package.json as template for pkg/package.json - #807
Open
kylebarron wants to merge 1 commit into
Open
fix: Use node package.json as template for pkg/package.json#807kylebarron wants to merge 1 commit into
kylebarron wants to merge 1 commit into
Conversation
|
|
Hey @kylebarron, I ran into this and I can confirm the fix in this PR would work for me. I have a local ESM project and was able to get -- >8 --
"scripts": {
"postinstall": "node -e \"const fs=require('fs'),p=JSON.parse(fs.readFileSync('./node_modules/parquet-wasm/package.json'));delete p.type;fs.writeFileSync('./node_modules/parquet-wasm/package.json',JSON.stringify(p,null,2));\"",
-- >8 -- |
Owner
Author
|
Thanks for the acknowledgement. I think we might need a wholesale re-architecting of how the builds are made, along with good dev docs about how it works |
|
Do you want to file an issue and put your thoughts down? And if you don't think you'd have time to do it, I can try. |
Owner
Author
|
I don't have the time/energy to put into this project right now 😕 Happy to follow your suggestions to unblock some of these recurrent issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.