Skip to content

fix(applaunchpad): preserve network resources on storage update - #7165

Open
mlhiter wants to merge 3 commits into
labring:release-v5.1from
mlhiter:volume-hides-network-config
Open

fix(applaunchpad): preserve network resources on storage update#7165
mlhiter wants to merge 3 commits into
labring:release-v5.1from
mlhiter:volume-hides-network-config

Conversation

@mlhiter

@mlhiter mlhiter commented Aug 5, 2026

Copy link
Copy Markdown
Member

Summary

  • Preserve existing Service, Ingress, cert-manager, HPA, ConfigMap, and Secret resources when an App Launchpad update replaces a Deployment with a StatefulSet for storage changes.
  • Create the replacement workload first, move dependent ownerReferences to the new workload, then delete the old workload.
  • Add a unit regression test for the ownerReference migration order.

Sequence Diagram

sequenceDiagram
    participant User
    participant UpdateAPI as /api/updateApp
    participant K8s as Kubernetes API
    participant OldWorkload as Old Deployment
    participant NewWorkload as New StatefulSet
    participant Network as Existing network resources

    User->>UpdateAPI: Submit storage update
    UpdateAPI->>K8s: Create replacement StatefulSet
    K8s-->>UpdateAPI: Return new workload UID
    UpdateAPI->>Network: Patch ownerReferences to new StatefulSet
    UpdateAPI->>OldWorkload: Delete old Deployment
    UpdateAPI-->>User: Return success without deleting network config
Loading

Verification

  • pnpm --dir frontend/providers/applaunchpad exec tsc --noEmit --pretty false
  • pnpm --dir frontend/providers/applaunchpad lint
  • git diff --check origin/release-v5.1...HEAD

@mlhiter
mlhiter requested a review from a team as a code owner August 5, 2026 09:03
@mlhiter mlhiter added this to the v5.1 milestone Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant