fix(applaunchpad): preserve instance ownership for recreated resources - #7188
Open
PRINCEofAsgd wants to merge 1 commit into
Open
fix(applaunchpad): preserve instance ownership for recreated resources#7188PRINCEofAsgd wants to merge 1 commit into
PRINCEofAsgd wants to merge 1 commit into
Conversation
Signed-off-by: yinzy <1519173764@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
cloud.sealos.io/deploy-on-sealoslabel from the existing Deployment or StatefulSet.404 NotFoundresponses during deletion as success, making resource deletion idempotent.Why is this needed?
When an App Store application port is removed and recreated through App Launchpad, the newly created Service or Ingress loses the ownership metadata established by the App Store Instance.
Deleting the Instance then removes the original workload resources, but the recreated network resources can remain in the namespace.
During validation, attaching recreated resources directly to the Deployment or StatefulSet exposed another lifecycle issue: StatefulSets can be deleted and recreated during updates, causing Kubernetes to garbage-collect the Service before the explicit delete operation runs. This produced a false
500response even though the Service had already been deleted.This PR therefore inherits the stable App Store
InstanceownerReference instead of making the replaceable workload the ownership root.Fixes #7187
How was this tested?
Automated tests
Manual verification