Skip to content

Fix FormControl aria-describedby attribute handling for improved accessibility #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
codegen-sh wants to merge 2 commits into from
Closed

Fix FormControl aria-describedby attribute handling for improved accessibility #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea20348
Fix FormControl aria-describedby attribute handling
codegen-sh[bot] Aug 20, 2025
7181659
Update yarn.lock for @lambdacurry/forms v0.19.5
codegen-sh[bot] Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,10 @@
"name": "forms",
"version": "0.2.0",
"private": true,
"workspaces": ["apps/*", "packages/*"],
"workspaces": [
"apps/*",
"packages/*"
],
"scripts": {
"start": "yarn dev",
"dev": "turbo run dev",
Expand Down
2 changes: 1 addition & 1 deletion packages/components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@lambdacurry/forms",
"version": "0.19.4",
"version": "0.19.5",
"type": "module",
"main": "./dist/index.js",
"types": "./dist/index.d.ts",
Expand Down
7 changes: 6 additions & 1 deletion packages/components/src/ui/form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,14 @@ export function FormControl({ Component, ...props }: FormControlProps) {
const computedDescriptionId = fromPropsDesc ?? context.formDescriptionId;
const computedMessageId = fromPropsMsg ?? context.formMessageId;

// Fix: Only include aria-describedby if there's an error or description
const ariaDescribedBy = [];
if (computedDescriptionId) ariaDescribedBy.push(computedDescriptionId);
if (error && computedMessageId) ariaDescribedBy.push(computedMessageId);

const ariaProps = {
id: computedId,
'aria-describedby': error ? `${computedDescriptionId} ${computedMessageId}` : computedDescriptionId,
...(ariaDescribedBy.length > 0 ? { 'aria-describedby': ariaDescribedBy.join(' ') } : {}),
'aria-invalid': !!error,
} as const;

Expand Down